Improving Exception Handling in acados Python Template #1478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! |
….py to more specific types
…, and acados_sim_solver.py to more specific types
…py, penalty_utils.py, and zoro_description.py to more specific types
…ver_pyx.pyx to more specific types
|
@FreyJo Hi FreyJo, I believe I have changed all Exceptions in the python template to a more specific one. Could you please review them? |
|
Hi FreyJo, I have resolved all the conflicts, would you like to check them? |
d698bad to
46d31f1
Compare
FreyJo
approved these changes
Apr 4, 2025
|
It seems there are still errors in the cython wrapper. Unfortunately, and there is also a new conflict. Sorry for the inconvenience. |
|
I should have fixed the bug and solved the conflict. Could you approve the workflow to check them again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi acados team,
I recently noticed that the exceptions in the acados Python template are too broad for the issues they represent, which makes it difficult to catch specific errors in higher-level code. Would you like me to replace general Exception usages with more specific exception types?
I’ve made a sample change in utils.py. It's also possible to define several new custom error types for acados, if needed. If you're okay with this direction, I can continue updating the exceptions in the other files as well.