should indicate @param bool|null in doc block

I just checked the PHP documentation and I don't think this parameter is actually nullable, it's just optional. I think it's the difference between a variable being equal to null and a variable being unset.

wright, when you give a default value (other than null), it is not null

Objection lifted your honor. But Travis is still objecting.

Sounds good! Leaving the below post up in case it helps someone else.

I'm not sure that I understand. What I'm saying is that this variable should never be null so I don't think the suggestion to add |null is correct. That change would make it seem like you are allowed to call the function like this:

passwordAuthenticate('user', 'pass', null);

But this will give an error.

You are allowed to do this:

passwordAuthenticate('user', 'pass');

but in this case $redirect is initially unset, not null. They're different in PHP. In this case the default argument will set it to a bool.

So there is no case where $redirect is allowed to be null (even though it is optional).

bool $redirect = null would have required
@param bool|null .... and
?bool $redirect = null

giving a default value of true make it never to be null

About Travis, it is just a note that Travis failed (possibly not related, I haven't check)

Sorry Travis hasn't finish working, not the same

This declare causes the issue. If remove this line, it will pass the test.
https://belitsoft.com/php-development-services/php-7-review-new-features-scalar-type-declarations-and-return-type-declarations

Fatal error: Uncaught TypeError: DateTime::__construct() expects parameter 1 to be string, null given in /app/php/libraries/SinglePointLogin.class.inc:447 Stack trace: #0 /app/php/libraries/SinglePointLogin.class.inc(447): DateTime->__construct(NULL) #1 /app/php/libraries/SinglePointLogin.class.inc(322): SinglePointLogin->disabledDueToInactivity('UnitTester', 365) #2 /app/php/libraries/SinglePointLogin.class.inc(204): SinglePointLogin->passwordAuthenticate('UnitTester', '4test4') #3 /app/php/libraries/NDB_Client.class.inc(161): SinglePointLogin->authenticate() #4 /app/htdocs/index.php(22): NDB_Client->initialize() #5 /app/htdocs/router.php(74): include_once('/app/htdocs/ind...') #6 {main} thrown in /app/php/libraries/SinglePointLogin.class.inc on line 447

Thanks! I'll review the bug