-
Notifications
You must be signed in to change notification settings - Fork 189
Untitled #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Untitled #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for Candidate_Age and Window_Difference in non-proband instruments
1 task
HenriRabalais
referenced
this pull request
in HenriRabalais/Loris
Feb 17, 2020
[Candidate_list] Override
driusan
added a commit
that referenced
this pull request
Oct 29, 2021
When accessing an instrument from RB, I got the error: ``` Fatal error: Uncaught TypeError: Argument 1 passed to ValidatableIdentifier::__construct() must be of the type string, null given, called in /home/driusan/Code/Loris/php/libraries/NDB_BVL_Instrument.class.inc on line 2863 and defined in /home/driusan/Code/Loris/php/libraries/Valida tableIdentifier.php:57 Stack trace: #0 /home/driusan/Code/Loris/php/libraries/NDB_BVL_Instrument.class.inc(2863): ValidatableIdentifier->__co nstruct(NULL) #1 /home/driusan/Code/Loris/src/Middleware/UserPageDecorationMiddleware.php(241): NDB_BVL_Instrument->handle(Object(Laminas\Dia ctoros\ServerRequest)) #2 /home/driusan/Code/Loris/src/Middleware/PageDecorationMiddleware.php(57): LORIS\Middleware\UserPageDecorationMiddle ware->process(Object(Laminas\Diactoros\ServerRequest), Object(NDB_BVL_Instrument_aosi)) #3 /home/driusan/Code/Loris/php/libraries/NDB_Page.cl ass.inc(735): LORIS\Middleware\PageDecorationMiddleware->process(Object(Laminas\Diactoros\ServerRequest), Object(NDB_BVL_Instrument_aosi)) #4 /home/driusan/Code/Loris/php/libraries/NDB_BVL_In in /home/driusan/Code/Loris/php/libraries/ValidatableIdentifier.php on line 57 ``` This fixes the type error so that the instrument page loads.
KLaFleur
pushed a commit
to KLaFleur/Loris
that referenced
this pull request
Sep 20, 2022
Update for new functions
driusan
added a commit
that referenced
this pull request
Jun 21, 2023
The CommentID is not part of the data, it's the foreign key used between the flag table and the instrument table. JSON-based instruments do not have it, and this ensures better consistency between the two so that issues such as #8796 and #8801 will not vary based on instrument type and will be caught sooner. Resolves part of #8804 (Inconsistency #2)
driusan
pushed a commit
that referenced
this pull request
Jan 9, 2025
Fix PHP Fatal error: Uncaught TypeError: substr(): Argument #2 ($offset) must be of type int, false given in /var/www/Loris/php/libraries/NDB_BVL_Instrument_LINST.class.inc:172 from the BMI instrument.
This was referenced Feb 25, 2025
driusan
pushed a commit
that referenced
this pull request
Apr 11, 2025
This fixes the following errors when running the tool `fix_timepoint_date_problems.php` ``` PHP Fatal error: Uncaught TypeError: preg_match(): Argument #2 ($subject) must be of type string, LORIS\StudyEntities\Candidate\CandID given in /var/www/Loris/tools/fix_timepoint_date_problems.php:157 Stack trace: #0 /var/www/Loris/tools/fix_timepoint_date_problems.php(157): preg_match() #1 {main} thrown in /var/www/Loris/tools/fix_timepoint_date_problems.php on line 157 ``` ``` PHP Fatal error: Uncaught TypeError: checkdate(): Argument #1 ($month) must be of type int, string given in /var/www/Loris/tools/fix_timepoint_date_problems.php:519 Stack trace: #0 /var/www/Loris/tools/fix_timepoint_date_problems.php(519): checkdate() #1 /var/www/Loris/tools/fix_timepoint_date_problems.php(244): fixDate() #2 {main} thrown in /var/www/Loris/tools/fix_timepoint_date_problems.php on line 519 ``` ``` PHP Warning: Undefined variable $db in /var/www/Loris/php/libraries/NDB_BVL_Feedback.class.inc on line 717 PHP Fatal error: Uncaught Error: Call to a member function pselectOne() on null in /var/www/Loris/php/libraries/NDB_BVL_Feedback.class.inc:717 Stack trace: #0 /var/www/Loris/tools/fix_timepoint_date_problems.php(553): NDB_BVL_Feedback->createThread() #1 /var/www/Loris/tools/fix_timepoint_date_problems.php(244): fixDate() #2 {main} thrown in /var/www/Loris/php/libraries/NDB_BVL_Feedback.class.inc on line 717 ```
1 task
driusan
pushed a commit
that referenced
this pull request
Dec 3, 2025
The REDcap "radio option" sometimes includes no index and, in this case, a decimal (float) causing redcap2linst show the following error: PHP Fatal error: Uncaught DomainException: Could not parse radio option: '0.01 ' in /var/www/loris/project/modules/redcap/php/client/models/redcapdictionaryrecord.class.inc:316 Stack trace: #0 /var/www/loris/project/modules/redcap/php/client/models/redcapdictionaryrecord.class.inc(268): LORIS\redcap\client\models\RedcapDictionaryRecord->_optionsToLINST() #1 /var/www/loris/project/tools/redcap2linst.php(74): LORIS\redcap\client\models\RedcapDictionaryRecord->toLINST() #2 {main} thrown in /var/www/loris/project/modules/redcap/php/client/models/redcapdictionaryrecord.class.inc on line 316 the fetch was 0.01 | 0.05 | 0.10 | 0.15 without indices, But this code fixes it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Category: Cleanup
PR or issue introducing/requiring at least one clean-up operation
Category: Feature
PR or issue that aims to introduce a new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We haven't had a merge from IBIS to Loris Trunk since the initial move to github, and even then it wasn't complete. I think we to get the Loris Trunk completely up to date now that NeuroDevNet are (very) soon going to start using it.