Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[genomic_browser] Download button not showing up in the Files tab. #7856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maltheism wants to merge 11 commits into from
Closed

[genomic_browser] Download button not showing up in the Files tab. #7856

maltheism wants to merge 11 commits into from

Conversation

@maltheism
Copy link
Member

@maltheism maltheism commented Nov 25, 2021

Brief summary of changes

Made the name column a link for downloading. Note: This module needs refactoring of the upload and download logic to be more robust.

Link(s) to related issue(s)

@maltheism maltheism added Category: Bug PR or issue that aims to report or fix a bug 24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 labels Nov 25, 2021
xlecours
xlecours previously requested changes Dec 16, 2021
View reviewed changes
@maltheism maltheism requested a review from xlecours December 16, 2021 22:56
@maltheism maltheism added State: Needs work PR awaiting additional work by the author to proceed and removed State: Needs work PR awaiting additional work by the author to proceed labels Dec 16, 2021
@maltheism
Copy link
Member Author

maltheism commented Dec 16, 2021

@xlecours ready for testing again

@maltheism maltheism force-pushed the main_genomics_download_fix branch from 09f2dec to cb5e18a Compare October 31, 2022 17:00
@xlecours
Copy link
Contributor

xlecours commented Nov 29, 2022

There is a conflict

@maltheism
Copy link
Member Author

maltheism commented Dec 2, 2022

@xlecours conflict removed

@laemtl
Copy link
Contributor

laemtl commented Mar 14, 2023 •
edited
Loading

Hi @ridz1208 , blablabla

@ridz1208 ridz1208 added this to the 25.0.0 milestone Mar 14, 2023
@ridz1208 ridz1208 removed this from the 25.0.0 milestone Mar 21, 2023
@ridz1208 ridz1208 added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Mar 21, 2023
@ridz1208 ridz1208 changed the base branch from main to 24.1-release March 23, 2023 23:41
@ridz1208 ridz1208 mentioned this pull request Mar 23, 2023
Merged
@ridz1208 ridz1208 closed this Mar 23, 2023
@ridz1208
Copy link
Collaborator

ridz1208 commented Mar 23, 2023

replaced by linked PR

@ridz1208 ridz1208 reopened this Mar 23, 2023
@ridz1208 ridz1208 changed the base branch from 24.1-release to main March 23, 2023 23:58
@ridz1208 ridz1208 closed this Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@driusan driusan Awaiting requested review from driusan

@racostas racostas Awaiting requested review from racostas

@xlecours xlecours Awaiting requested review from xlecours

Assignees

@ridz1208 ridz1208

Labels

24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Category: Bug PR or issue that aims to report or fix a bug State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[genomic_browser] Download button not showing up in the Files tab.

4 participants

@maltheism @xlecours @laemtl @ridz1208