[genomic_browser] Download button not showing up in the Files tab #8480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5c7d726 to
bb76c32
Compare
bb76c32 to
5d33f01
Compare
Collaborator
Author
|
@racostas can you please test this |
racostas
approved these changes
Dec 5, 2023
Contributor
racostas
left a comment
There was a problem hiding this comment.
- PR working fine on 24.1-release branch.
- If intended for main, need to be rebased.
- Test plan need to be updated since now the file is downloaded when clicking on it, not in a button as mentioned in the test plan.
- Agree with the comments in the PR: the whole module seems to be a bit obsolete/needing major refactor.
I'm approving it, just leaving this notes here in case we want to revisit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Made the name column a link for downloading. Note: This module needs refactoring of the upload and download logic to be more robust.
Link(s) to related issue(s)
remake of #7856