-
Notifications
You must be signed in to change notification settings - Fork 189
[issue_tracker] Add more granular permissions for Issue Tracker #9554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[issue_tracker] Add more granular permissions for Issue Tracker #9554
Conversation
|
@kongtiaowang can you review this PR for me? Thanks |
|
@shonibare The "issue_tracker_close_all_issue: Close all Issues" permission seems unnecessary. In which specific scenarios is it used? If a user has only this permission, they cannot access the module. However, when combined with any of the "Issue Tracker: See/Edit/Comment and Close" permissions, the user gains full access. These three permissions together already include the ability to close issues independently. |
|
@Shen, the The |
kongtiaowang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@shonibare this has conflicts, can you rebase it? |
|
I am not going to block on this because this works and has been tested, but in the future I think a better design would be to move the permission checking logic into the |
Related to #8897
This PR modifies the existing permissions for the
issue_trackermodule. The permission has been extended to 5 permissions instead of 2. The permissions are as follows;issue_tracker_own_issue: See/Edit/Comment and Close on Own Issuesissue_tracker_all_issue: See/Edit/Comment on all Issuesissue_tracker_site_issue: See/Edit/Comment on Own Site Issuesissue_tracker_close_site_issue: Close Own Site Issuesissue_tracker_close_all_issue: Close all IssuesTesting: