[tools] populateage complete revamp #2630

ridz1208 · 2017-03-05T21:16:18Z

The populateage.php tool is completely useless in its current state.

This PR creates a new PHP script that fixes candidate ages.

New functionality has been added:

check for null ages
check for incorrect ages
confirm changes

This tool is designed to fix automatically calculated ages in the databse instrument tables, additional functionality could be added if necessary

ridz1208 · 2017-03-24T17:08:54Z

Old behaviour was designed for manually populating candidate ages after data-entry.

This script needs testing on large data-sets @gluneau @sruthymathew123 can you please take a look at it ?

sruthymathew123 · 2017-03-27T20:21:06Z

@ridz1208: On running the script, I got the below error
PHP Fatal error: Uncaught LorisException: Could not select Candidate data from the database (DCCID: 532110) in /var/www/loris/project/libraries/Candidate.class.inc:61
Stack trace:
#0 /var/www/loris/project/libraries/Candidate.class.inc(36): Candidate->select('532110')
#1 /var/www/loris/php/libraries/TimePoint.class.inc(857): Candidate::singleton('532110')
#2 /var/www/loris/project/instruments/NDB_BVL_Instrument_adi_r_subject.class.inc(72): TimePoint->getEffectiveDateOfBirth()
#3 /var/www/loris/project/instruments/NDB_BVL_Instrument_adi_r.class.inc(73): NDB_BVL_Instrument_adi_r_subject->_getAge()
#4 /var/www/loris/project/instruments/NDB_BVL_Instrument_adi_r.class.inc(61): NDB_BVL_Instrument_adi_r->_setupForm()
#5 /var/www/loris/project/instruments/NDB_BVL_Instrument_adi_r_subject.class.inc(46): NDB_BVL_Instrument_adi_r->_setup('532110UNC000170...', NULL)
#6 /var/www/loris/php/libraries/NDB_BVL_Instrument.class.inc(209): NDB_BVL_Instrument_adi_r_subject->setup('532110UNC000170...', NULL)
#7 /var/www/loris/tools/fix_candidate_a in /var/www/loris/project/libraries/Candidate.class.inc on line 61

sruthymathew123 · 2017-03-27T20:22:43Z

@ridz1208 The above candidate is a not active candidate, but have tables associated with it.

ridz1208 · 2017-03-28T21:47:56Z

@sruthymathew123 I cannot reproduce, lets look at it on your VM ?

ridz1208 · 2017-03-28T21:49:22Z

@driusan @samirdas @LeighMac if a candidate is not active do we care about fixing its candidate_age fields ?

sruthymathew123 · 2017-03-29T16:59:41Z

@ridz. The query in candidate class on line 61 is failing for the above candidate. That is why the script is failing.

ridz1208 · 2017-03-30T15:46:21Z

@sruthymathew123 please re-test

sruthymathew123 · 2017-03-31T02:29:41Z

@ridz1208

PHP Fatal error: Uncaught Exception: Failed to retrieve data for timepoint (2418) in /var/www/loris/php/libraries/TimePoint.class.inc:142
Stack trace:
#0 /var/www/loris/php/libraries/TimePoint.class.inc(87): TimePoint->select('2418')
#1 /var/www/loris/project/instruments/NDB_BVL_Instrument_adi_r_subject.class.inc(71): TimePoint::singleton('2418')
#2 /var/www/loris/project/instruments/NDB_BVL_Instrument_adi_r.class.inc(73): NDB_BVL_Instrument_adi_r_subject->_getAge()
#3 /var/www/loris/project/instruments/NDB_BVL_Instrument_adi_r.class.inc(61): NDB_BVL_Instrument_adi_r->_setupForm()
#4 /var/www/loris/project/instruments/NDB_BVL_Instrument_adi_r_subject.class.inc(46): NDB_BVL_Instrument_adi_r->_setup('802278SEA013224...', NULL)
#5 /var/www/loris/php/libraries/NDB_BVL_Instrument.class.inc(209): NDB_BVL_Instrument_adi_r_subject->setup('802278SEA013224...', NULL)
#6 /var/www/loris/tools/fix_candidate_age.php(56): NDB_BVL_Instrument::factory('adi_r_subject', '802278SEA013224...', NULL, false)
#7 {main}
thrown in /var/www/loris/php/libraries/TimePoint.class.inc on line 142

ridz1208 · 2017-03-31T14:49:11Z

@sruthymathew123 and now ?

sruthymathew123 · 2017-03-31T16:49:13Z

Sorry @ridz1208

PHP Warning: Missing argument 4 for LorisForm::createElement(), called in /var/www/loris/project/instruments/NDB_BVL_Instrument_edi.class.inc on line 473 and defined in /var/www/loris/php/libraries/LorisForm.class.inc on line 1809
PHP Notice: Undefined variable: options in /var/www/loris/php/libraries/LorisForm.class.inc on line 1822
PHP Notice: Undefined index: DoB in /var/www/loris/php/libraries/NDB_BVL_Instrument.class.inc on line 1984
PHP Notice: Undefined index: Date_taken in /var/www/loris/php/libraries/NDB_BVL_Instrument.class.inc on line 1984
PHP Fatal error: Uncaught Exception: Argument 1 does not match expected date format (YYYY-MM-DD) in /var/www/loris/php/libraries/Utility.class.inc:100
Stack trace:
#0 /var/www/loris/php/libraries/NDB_BVL_Instrument.class.inc(1984): Utility::calculateAge(NULL, NULL)
#1 /var/www/loris/tools/fix_candidate_age.php(82): NDB_BVL_Instrument->getCandidateAge()
#2 {main}
thrown in /var/www/loris/php/libraries/Utility.class.inc on line 100

driusan · 2017-06-08T19:10:21Z

tools/fix_candidate_age.php

+
+    // Break if Date taken does not exist
+    if (!$DB->columnExists($inst, 'Date_taken')) {
+        continue;


should there be an error message printed here?

ridz1208 · 2017-06-09T01:06:21Z

@driusan error added

gluneau · 2017-06-09T16:07:17Z

tools/fix_candidate_age.php

+                // get Age from instrument class
+                $calculatedAge       = $instrument->getCandidateAge();
+                $agemonths           = $calculatedAge['year'] * 12 + $calculatedAge['mon'] + ($calculatedAge['day'] / 30);
+                $calculatedAgeMonths = (round($agemonths*10) / 10.0);


@driusan @ridz1208 Glad to see these formulas are the same as in the instrument library.

ridz1208 · 2017-06-09T18:17:16Z

@gluneau could you give it a quick try when you have a minute. I removed the code duplication

ridz1208 · 2017-06-13T18:36:07Z

@kongtiaowang HELP MEEEE

kongtiaowang · 2017-06-15T16:55:00Z

It failed - because this automation test find this
"The following errors occured while attempting to display this page:
The user with name does not exist in the database."

ridz1208 · 2017-06-16T19:53:40Z

@gluneau please re-test quickly, minor changes took place

driusan · 2017-06-27T16:59:58Z

Has this been tested in the latest incarnation? It moved from "Needs Testing" without any indication on the PR that that happened..

Jkat · 2018-07-11T17:45:08Z

Thank you 🙏

ridz1208 · 2018-07-12T19:15:01Z

@Jkat believe me MY PLEASURE lol

ridz1208 added 2 commits March 5, 2017 16:11

completely redone

0a98f36

Renamed

21b856f

ridz1208 added this to the 17.1 milestone Mar 5, 2017

ridz1208 assigned mohadesz and sruthymathew123 Mar 5, 2017

ridz1208 requested review from driusan and gluneau March 5, 2017 21:16

ridz1208 added the State: Discussion required PR or issue that requires the resolution of a discussion with the relevant parties to proceed label Mar 7, 2017

mohadesz added the State: Needs work PR awaiting additional work by the author to proceed label Mar 10, 2017

ridz1208 removed the State: Needs work PR awaiting additional work by the author to proceed label Mar 10, 2017

ridz1208 assigned gluneau Mar 24, 2017

ridz1208 removed the State: Discussion required PR or issue that requires the resolution of a discussion with the relevant parties to proceed label Mar 24, 2017

ridz1208 added the State: Needs work PR awaiting additional work by the author to proceed label Mar 28, 2017

ridz1208 added 2 commits March 30, 2017 11:39

Try catch for inactive candidates

90a3396

phpcs

bd531b7

ridz1208 removed the State: Needs work PR awaiting additional work by the author to proceed label Mar 30, 2017

timepoint handling

ff51770

driusan reviewed Jun 8, 2017

View reviewed changes

Create fix_candidate_age.php

7cfa721

gluneau reviewed Jun 9, 2017

View reviewed changes

ridz1208 added the State: Needs work PR awaiting additional work by the author to proceed label Jun 9, 2017

avoid code dup

2df6647

Instanciate user in client

1246ca2

ridz1208 removed State: Needs work PR awaiting additional work by the author to proceed Passed manual tests PR has been successfully tested by at least one peer labels Jun 9, 2017

ridz1208 added 8 commits June 12, 2017 11:34

Throw error

1f642c9

add user to travis DB

b4ceae1

add user to travis DB oops

a0fd584

grrrr

450c778

grrrr

398c6a0

grrrr

e7b21cc

travis

63d9b19

travis

b2cd3b5

removed error

926cc47

only comment Id

949f088

ridz1208 added the Passed manual tests PR has been successfully tested by at least one peer label Jun 27, 2017

driusan merged commit f5107e9 into aces:17.1-dev Jul 4, 2017

Jkat unassigned gluneau Jul 11, 2018

[tools] populateage complete revamp #2630

[tools] populateage complete revamp #2630

Uh oh!

Conversation

ridz1208 commented Mar 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ridz1208 commented Mar 24, 2017

Uh oh!

sruthymathew123 commented Mar 27, 2017

Uh oh!

sruthymathew123 commented Mar 27, 2017

Uh oh!

ridz1208 commented Mar 28, 2017

Uh oh!

ridz1208 commented Mar 28, 2017

Uh oh!

sruthymathew123 commented Mar 29, 2017

Uh oh!

ridz1208 commented Mar 30, 2017

Uh oh!

sruthymathew123 commented Mar 31, 2017

Uh oh!

ridz1208 commented Mar 31, 2017

Uh oh!

sruthymathew123 commented Mar 31, 2017

Uh oh!

driusan Jun 8, 2017

Choose a reason for hiding this comment

Uh oh!

ridz1208 commented Jun 9, 2017

Uh oh!

gluneau Jun 9, 2017

Choose a reason for hiding this comment

Uh oh!

ridz1208 commented Jun 9, 2017

Uh oh!

ridz1208 commented Jun 13, 2017

Uh oh!

kongtiaowang commented Jun 15, 2017

Uh oh!

ridz1208 commented Jun 16, 2017

Uh oh!

driusan commented Jun 27, 2017

Uh oh!

Jkat commented Jul 11, 2018

Uh oh!

ridz1208 commented Jul 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

ridz1208 commented Mar 5, 2017 •

edited

Loading