Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: split extras by features #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amuraru merged 8 commits into from
Jun 10, 2022
Merged

feat: split extras by features #95

amuraru merged 8 commits into from
Jun 10, 2022

Conversation

@aslafy-z
Copy link
Contributor

@aslafy-z aslafy-z commented Jun 7, 2022 •
edited
Loading

Description

Related Issue

#44

Motivation and Context

Allow users to choose which extras should be installed (eg: no need for AWS packages when working only with vault)

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

aslafy-z
aslafy-z commented Jun 7, 2022
View reviewed changes
aslafy-z
aslafy-z commented Jun 7, 2022
View reviewed changes
aslafy-z
aslafy-z commented Jun 7, 2022
View reviewed changes
aslafy-z
aslafy-z commented Jun 7, 2022
View reviewed changes
aslafy-z
aslafy-z commented Jun 7, 2022
View reviewed changes
aslafy-z
aslafy-z commented Jun 7, 2022
View reviewed changes
aslafy-z
aslafy-z commented Jun 7, 2022
View reviewed changes
aslafy-z
aslafy-z commented Jun 9, 2022
View reviewed changes
@aslafy-z aslafy-z marked this pull request as ready for review June 9, 2022 09:53
@aslafy-z aslafy-z requested a review from amuraru June 9, 2022 09:53
@amuraru amuraru merged commit 1be8d3a into adobe:master Jun 10, 2022
@aslafy-z aslafy-z deleted the patch-1 branch June 11, 2022 07:48
@aslafy-z aslafy-z restored the patch-1 branch August 3, 2023 16:51
@aslafy-z aslafy-z mentioned this pull request Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amuraru amuraru amuraru approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aslafy-z @amuraru