Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: split extras by features #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amuraru merged 19 commits into from
Oct 11, 2025
Merged

feat: split extras by features #144

amuraru merged 19 commits into from
Oct 11, 2025

Conversation

@aslafy-z
Copy link
Contributor

@aslafy-z aslafy-z commented Aug 3, 2023 •
edited
Loading

Follow up #95 that was reverted at 6fa86f4

Fixes #44

Test with

pip install -e git+https://github.com/adobe/himl.git@refs/pull/144/head#egg=himl
pip install -e git+https://github.com/adobe/himl.git@refs/pull/144/head#egg=himl[vault]
pip install -e git+https://github.com/adobe/himl.git@refs/pull/144/head#egg=himl[s3]
pip install -e git+https://github.com/adobe/himl.git@refs/pull/144/head#egg=himl[all]

aslafy-z
aslafy-z commented Aug 3, 2023
View reviewed changes
aslafy-z
aslafy-z commented Aug 3, 2023
View reviewed changes
aslafy-z
aslafy-z commented Dec 5, 2023
View reviewed changes
aslafy-z
aslafy-z commented Dec 5, 2023
View reviewed changes
@aslafy-z aslafy-z marked this pull request as ready for review December 5, 2023 16:26
@aslafy-z
Copy link
Contributor Author

aslafy-z commented Feb 14, 2024

@amuraru Hey, can you please give a look? I would love to use to project without pulling 90% libraries I don't need. Thank you!

@danielcoman danielcoman self-requested a review December 26, 2024 16:05
amuraru
amuraru approved these changes Oct 11, 2025
View reviewed changes
Copy link
Contributor

@amuraru amuraru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@amuraru amuraru merged commit ce8437d into adobe:master Oct 11, 2025
@aslafy-z aslafy-z deleted the patch-1 branch October 11, 2025 14:48
@aslafy-z
Copy link
Contributor Author

aslafy-z commented Oct 11, 2025

@amuraru I can't find the merged commits. I can rebase and squash the commits if you want.

amuraru pushed a commit that referenced this pull request Oct 11, 2025
@aslafy-z @amuraru
feat: split extras by features (#144)
1260bc2
@amuraru
Copy link
Contributor

amuraru commented Oct 12, 2025

It went in 0.18.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amuraru amuraru amuraru approved these changes

@danielcoman danielcoman Awaiting requested review from danielcoman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use setuptools extras for extra dependencies

2 participants

@aslafy-z @amuraru