[fix] Copy the keys of RunStatusReporter.timed_tasks before iterating them #3256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
Hey @VassilisVassiliadis! Thanks a lot for opening the fix. Can I just ask you to update the changelog as well? |
Iterating the dictionary self.timed_tasks sometimes raises the following exception: > RuntimeError: dictionary changed size during iteration The solution is to copy the keys of RunStatusReporter.timed_tasks before iterating over them Signed-off-by: Vassilis Vassiliadis <[email protected]>
639b3b6 to
246bc42
Compare
Contributor
Author
|
Hi @mihran113 I rebased my PR and added an entry in the Changelog. |
Contributor
|
Hey @VassilisVassiliadis. Sorry, there was some mistiming, I pushed some changes to the main in the meantime, but I've resolved the conflicts and merged the PR. Thanks again. |
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterating the dictionary self.timed_tasks sometimes raises the following exception:
This PR resolves #3181
https://github.com/GuHongyang actually included the fix to the issue they opened ( #3181 )