Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[fix] Copy the keys of RunStatusReporter.timed_tasks before iterating them #3256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mihran113 merged 2 commits into from
Dec 5, 2024
Merged

[fix] Copy the keys of RunStatusReporter.timed_tasks before iterating them #3256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
246bc42
[fix] Stop dictionary keys changed during iteration exception
VassilisVassiliadis Nov 26, 2024
0422874
Merge branch 'main' into main
mihran113 Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
# Changelog

## Unreleased
## Unreleased:

### Fixes:
- Fix aggregated metrics' computations (mihran113)
- Fix bug in RunStatusReporter raising non-deterministic RuntimeError exception (VassilisVassiliadis)


## 3.26.1 Dec 3, 2024
- Re-upload after PyPI size limitation fix
Expand Down
2 changes: 1 addition & 1 deletion aim/sdk/reporter/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,7 +655,7 @@ def flush(
logger.debug(f'notifying {self}')

with self.reporter_lock:
flag_names = [flag_name] if flag_name is not None else self.timed_tasks
flag_names = [flag_name] if flag_name is not None else list(self.timed_tasks)
with self.flush_condition:
for flag_name in flag_names:
logger.debug(f'flushing {flag_name}')
Expand Down