Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix mvplot #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akanz1 merged 3 commits into from
Dec 17, 2021
Merged

Fix mvplot #15

akanz1 merged 3 commits into from
Dec 17, 2021

Conversation

@akanz1
Copy link
Owner

@akanz1 akanz1 commented Dec 17, 2021

Fixes the y-axis label for cases with a very low ratio of missing values.

Closes #14

@akanz1 akanz1 self-assigned this Dec 17, 2021
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 17, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 7.04 ⭐ 7.04 ⭐ 0.00
Method Length 163.42 😞 163.37 😞 -0.05 👍
Working memory 18.35 ⛔ 18.35 ⛔ 0.00
Quality 40.45% 😞 40.45% 😞 0.00%
Other metrics Before After Change
Lines 1018 1016 -2
Changed files Quality Before Quality After Quality Change
klib/describe.py 32.02% 😞 32.02% 😞 0.00%
klib/utils.py 62.29% 🙂 62.29% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
klib/describe.py cat_plot 13 🙂 584 ⛔ 24 ⛔ 23.41% ⛔ Try splitting into smaller methods. Extract out complex expressions
klib/describe.py missingval_plot 6 ⭐ 658 ⛔ 24 ⛔ 29.74% 😞 Try splitting into smaller methods. Extract out complex expressions
klib/describe.py dist_plot 9 🙂 665 ⛔ 18 ⛔ 30.19% 😞 Try splitting into smaller methods. Extract out complex expressions
klib/describe.py corr_plot 2 ⭐ 230 ⛔ 27 ⛔ 39.39% 😞 Try splitting into smaller methods. Extract out complex expressions
klib/utils.py _diff_report 4 ⭐ 342 ⛔ 14 😞 41.46% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Dec 17, 2021 •
edited
Loading

Codecov Report

Merging #15 (30eab91) into main (42165c1) will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #15   +/-   ##
=======================================
  Coverage   49.53%   49.53%           
=======================================
  Files           4        4           
  Lines         541      541           
=======================================
  Hits          268      268           
  Misses        273      273
Impacted Files Coverage Δ
klib/describe.py 15.76% <0.00%> (ø)
klib/utils.py 80.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42165c1...30eab91. Read the comment docs.

@akanz1 akanz1 merged commit f9fdb58 into main Dec 17, 2021
@akanz1 akanz1 deleted the fix-mvplot branch December 17, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@akanz1 akanz1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] - Broken missing values plot for small percentage of missing values

2 participants

@akanz1