Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@akanz1
Copy link
Owner

@akanz1 akanz1 commented Dec 26, 2021

@akanz1 akanz1 self-assigned this Dec 26, 2021
Andreas Kanz added 2 commits December 26, 2021 13:01
Repository owner deleted a comment from sourcery-ai bot Dec 26, 2021
Repository owner deleted a comment from sourcery-ai bot Dec 26, 2021
@codecov
Copy link

codecov bot commented Dec 26, 2021

Codecov Report

Merging #17 (a3b5d61) into main (5b7cd63) will increase coverage by 1.47%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   49.53%   51.01%   +1.47%     
==========================================
  Files           4        4              
  Lines         541      541              
  Branches        0       72      +72     
==========================================
+ Hits          268      276       +8     
+ Misses        273      255      -18     
- Partials        0       10      +10     
Impacted Files Coverage Δ
src/klib/describe.py 15.31% <66.66%> (ø)
src/klib/clean.py 66.10% <100.00%> (ø)
src/klib/preprocess.py 75.47% <100.00%> (ø)
src/klib/utils.py 95.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b7cd63...a3b5d61. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Dec 26, 2021

This pull request introduces 1 alert and fixes 1 when merging 17c8dc2 into 5b7cd63 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 1 for Unused import

Repository owner deleted a comment from sourcery-ai bot Dec 26, 2021
@lgtm-com
Copy link

lgtm-com bot commented Dec 26, 2021

This pull request introduces 1 alert and fixes 1 when merging 24b9265 into 5b7cd63 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 1 for Unused import

Repository owner deleted a comment from sourcery-ai bot Dec 26, 2021
@lgtm-com
Copy link

lgtm-com bot commented Dec 26, 2021

This pull request introduces 1 alert and fixes 1 when merging 9076ee9 into 5b7cd63 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Dec 26, 2021

This pull request introduces 1 alert and fixes 1 when merging 1cefec8 into 5b7cd63 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 1 for Unused import

Andreas Kanz added 2 commits December 26, 2021 16:18
Repository owner deleted a comment from sourcery-ai bot Dec 26, 2021
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 26, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 31.59%.

Quality metrics Before After Change
Complexity 4.04 ⭐ 0.00 ⭐ -4.04 👍
Method Length 83.60 🙂 61.00 ⭐ -22.60 👍
Working memory 12.38 😞 3.00 ⭐ -9.38 👍
Quality 60.09% 🙂 91.68% 31.59% 👍
Other metrics Before After Change
Lines 2748 59 -2689
Changed files Quality Before Quality After Quality Change
docs/source/conf.py 90.90% ⭐ 91.68% ⭐ 0.78% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 23 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@akanz1 akanz1 merged commit e1fde81 into main Dec 26, 2021
@akanz1 akanz1 deleted the reorganize-package branch December 26, 2021 15:43
@lgtm-com
Copy link

lgtm-com bot commented Dec 26, 2021

This pull request introduces 1 alert and fixes 1 when merging a3b5d61 into 5b7cd63 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 1 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - Broken missing values plot for small percentage of missing values Switch to poetry

2 participants