Log errors over printing #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzantow
previously approved these changes
Nov 7, 2024
Signed-off-by: Alex Goodman <[email protected]>
863ffc4 to
8dc4a8f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Alex Goodman <[email protected]>
kzantow
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Something about this doesn't sit especially well with me, but I believe it should fix the issue. I wonder if we could adjust where the init happens, maybe through some PersistentPreRun kind of function, but it would require more research whether this continues to run prior to cobra errors on child commands/other edge cases/etc..
|
I agree there may be a more elegant solution, but for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we print errors to stderr manually, however, we should be using the logger for this when it is available.