Allow CPE parsing failures #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Luhring <[email protected]>
Signed-off-by: Dan Luhring <[email protected]>
kzantow
approved these changes
Sep 22, 2021
| value, err := pkg.NewCPE(c) | ||
| if err != nil { | ||
| return nil, err | ||
| log.Warnf("unable to hydrate CPE for string %q, omitting from result CPE slice: %v", c, err) |
There was a problem hiding this comment.
maybe "hydrate" -> "parse" ? or less verbose: "Excluding invalid CPE %q: %v"?
There was a problem hiding this comment.
@kzantow I like that! I'll create a PR for this
This was referenced Sep 23, 2021
spiffcs
added a commit
that referenced
this pull request
Oct 1, 2021
* main: Support gomod configuration in goreleaser (#391) Update description for Slack link (#439) Updates approach for epoch handling in rpm comparisons (#438) Feature: Specifying ignore rules for vulnerability matches (#430) Update Syft to v0.24.1 (#433) pull in grype-db default language namespace namer + fix imbalanced version v prefixes (#434) add stock matcher (language + cpe matching) (#432) Add SBOM to releases (#429) Add announcement for KubeCon meetup (#428) Improve log message for CPE parsing error (#426) Bugfixes + Integration test for sbom input vs grype library comparison (#424) Allow CPE parsing failures (#425)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #417.
When Grype reads in a user-supplied SBOM from Syft, it needs to convert CPE strings into CPE objects. When malformed CPE strings are supplied, Grype errored out and provided no useful results.
This PR adjusts the CPE parsing logic (within Syft JSON parsing) to log a warning instead of returning an error in the scenario where a user-supplied CPE string cannot be parsed successfully, allowing the logic to continue to other CPEs and other packages that don't have any parsing issues.
Note: We should also make an adjustment in Syft to avoid the creation of malformed CPE strings.