Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: catalog python files for installed-files.txt file metadata #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 19, 2022
Merged

feat: catalog python files for installed-files.txt file metadata #1217

merged 7 commits into from
Sep 19, 2022

Conversation

@spiffcs
Copy link
Contributor

@spiffcs spiffcs commented Sep 19, 2022

Refs for remote PR encountered a small bug so opening this PR as the merge candidate for this feature

See #947 for PR details.

Signed-off-by: houdini91 [email protected]

houdini91 and others added 5 commits April 12, 2022 11:30
@houdini91
suggestion catalog python files for installed-files.txt file metadata
dfe2085 
Signed-off-by: houdini91 <[email protected]>
@houdini91
rename args
84e6c35 
Signed-off-by: houdini91 <[email protected]>
@houdini91
fix lint
5a4f730 
Signed-off-by: houdini91 <[email protected]>
@spiffcs
refactor: no critical error for file parse
920d1b4 
	remove critical error path for installed-files parse failure

Signed-off-by: Christopher Phillips <[email protected]>
@spiffcs
Merge branch 'main' into suggestion/egg_files_metadata
6ba0ffd
@github-actions
Copy link

github-actions bot commented Sep 19, 2022 •
edited
Loading

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/alpmdb-cataloger-2                    11.2ms ± 3%    14.7ms ± 3%  +30.85%  (p=0.008 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.28ms ± 1%    1.70ms ± 2%  +33.60%  (p=0.029 n=4+4)
ImagePackageCatalogers/python-package-cataloger-2            3.19ms ± 1%    4.45ms ± 8%  +39.46%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.04ms ± 0%    1.44ms ± 3%  +38.75%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         728µs ± 1%    1026µs ± 3%  +40.87%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     863µs ± 1%    1244µs ± 2%  +44.25%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpm-db-cataloger-2                    1.24ms ± 1%    1.73ms ± 2%  +39.90%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      14.1ms ± 1%    19.2ms ± 9%  +35.97%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.17ms ± 1%    1.66ms ±10%  +41.33%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          2.06µs ± 1%    3.21µs ± 3%  +56.09%  (p=0.008 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2               1.31ms ± 0%    1.84ms ± 3%  +40.02%  (p=0.008 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    690µs ± 0%     968µs ± 3%  +40.25%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/alpmdb-cataloger-2                    5.26MB ± 0%    5.26MB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               202kB ± 0%     202kB ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             944kB ± 0%     945kB ± 0%   +0.11%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     214kB ± 0%     214kB ± 0%     ~     (p=0.548 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         158kB ± 0%     158kB ± 0%     ~     (p=0.056 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     203kB ± 0%     203kB ± 0%     ~     (p=0.056 n=5+5)
ImagePackageCatalogers/rpm-db-cataloger-2                     302kB ± 0%     302kB ± 0%   -0.10%  (p=0.016 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.44MB ± 0%    3.44MB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.25MB ± 0%    1.25MB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            672B ± 0%      672B ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                369kB ± 0%     369kB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    136kB ± 0%     136kB ± 0%     ~     (p=0.841 n=5+5)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/alpmdb-cataloger-2                     85.7k ± 0%     85.7k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               4.25k ± 0%     4.25k ± 0%     ~     (p=0.556 n=5+4)
ImagePackageCatalogers/python-package-cataloger-2             16.6k ± 0%     16.6k ± 0%   +0.12%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     5.53k ± 0%     5.53k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         3.32k ± 0%     3.32k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     4.60k ± 0%     4.60k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpm-db-cataloger-2                     8.13k ± 0%     8.13k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       57.5k ± 0%     57.5k ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      5.43k ± 0%     5.43k ± 0%     ~     (p=1.000 n=4+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            15.0 ± 0%      15.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                7.27k ± 0%     7.27k ± 0%     ~     (all equal)
ImagePackageCatalogers/portage-cataloger-2                    3.59k ± 0%     3.59k ± 0%     ~     (all equal)

@spiffcs
update unit tests for installedFile
ae343fe 
Signed-off-by: Christopher Phillips <[email protected]>
kzantow
kzantow approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 very minor comments 👍

@spiffcs
pr review
9abdff7 
Signed-off-by: Christopher Phillips <[email protected]>
@spiffcs spiffcs force-pushed the suggestion/egg_files_metadata branch from a33093e to 9abdff7 Compare September 19, 2022 19:45
@spiffcs spiffcs changed the title suggestion catalog python files for installed-files.txt file metadata feat: catalog python files for installed-files.txt file metadata Sep 19, 2022
@spiffcs spiffcs enabled auto-merge (squash) September 19, 2022 19:57
@spiffcs spiffcs merged commit 04d288b into main Sep 19, 2022
@spiffcs spiffcs deleted the suggestion/egg_files_metadata branch September 19, 2022 20:08
@spiffcs spiffcs mentioned this pull request Sep 19, 2022
Closed
aiwantaozi pushed a commit to aiwantaozi/syft that referenced this pull request Oct 20, 2022
@spiffcs @houdini91 @aiwantaozi
feat: catalog python files for installed-files.txt file metadata (anc…
b2420b1 
…hore#1217)

Co-authored-by: houdini91 <[email protected]>
spiffcs added a commit that referenced this pull request Oct 21, 2022
@spiffcs @houdini91
feat: catalog python files for installed-files.txt file metadata (#1217)
d916e2d 
Co-authored-by: houdini91 <[email protected]>
Signed-off-by: Christopher Phillips <[email protected]>
spiffcs added a commit that referenced this pull request Oct 21, 2022
@spiffcs @houdini91
feat: catalog python files for installed-files.txt file metadata (#1217)
789739b 
Co-authored-by: houdini91 <[email protected]>
Signed-off-by: Christopher Phillips <[email protected]>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@spiffcs @houdini91
feat: catalog python files for installed-files.txt file metadata (anc…
8b18684 
…hore#1217)

Co-authored-by: houdini91 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzantow kzantow kzantow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spiffcs @kzantow @houdini91