Suggestion/egg files metadata #947
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: houdini91 <[email protected]>
Signed-off-by: houdini91 <[email protected]>
Signed-off-by: houdini91 <[email protected]>
kzantow
requested changes
Aug 15, 2022
There was a problem hiding this comment.
Hi @houdini91 -- this PR is looking pretty close but I think we'd like to see some basic tests added, would you be able to do this?
| if err == io.EOF { | ||
| break | ||
| } | ||
| if err != nil { |
There was a problem hiding this comment.
Should failure reading the installed-files be a critical error? The caller seems to treat it as critical, but as it wasn't even being done before maybe these should instead be warnings?
|
Merged with #1217 - Thanks again for all the help on this one @houdini91! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggesting enhancement to the python cataloger.
Catalog package files for legacy egg 'installed-files.txt' metadata.
For example
psycopg2does not have linux wheel so it uses egg, then django usespsycopg2and so one...https://github.com/pypa/pip/blob/1cda23bd6bd0066ad557e4f7ca7c670744357b2b/src/pip/_internal/operations/install/legacy.py
Note: It seemed that EGG
installed-files.txtand wheelRECORDuse paths that are relative to different base dirs.I added a normalization flow for the
installed-fiels.txtto the one used byRECORD.Installed-files.txt- relative to egg Info dir.RECORD- relative to site-packages root dir.