Enhance CPE generation #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
luhring
reviewed
Aug 9, 2021
| @@ -1,16 +1,27 @@ | |||
| package cataloger | |||
There was a problem hiding this comment.
It may be valuable soon (not necessarily now) to introduce a CPE-specific package. There seems to be a lot of rich logic and data, all within the context of the "CPE domain". I noticed that cpe.go is a bit on the large side, and also that we have several files in this directory that all start with cpe_.
There was a problem hiding this comment.
agreed (I resisted a lot of possible refactors on this PR that I think there is a lot of room for). My vote is to not do such refactors in this PR though.
…in fields Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
… logic Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
1419fe0 to
6d94148
Compare
|
rebased / force pushed to incorporate #474 |
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
* adjust CPE specificity sorting to include field length and bias certain fields Signed-off-by: Alex Goodman <[email protected]> * remove * vendor values from CPE generation Signed-off-by: Alex Goodman <[email protected]> * re-enable generating CPEs for jenkins and jira plugins Signed-off-by: Alex Goodman <[email protected]> * improve CPE generation logic based on java artifactID and groupID Signed-off-by: Alex Goodman <[email protected]> * add ruby-lang as target software candidate for gems in CPE generation logic Signed-off-by: Alex Goodman <[email protected]> * rename filterCpes to filterCPEs Signed-off-by: Alex Goodman <[email protected]> * refactor CPE filters and groupID processing (for linting) Signed-off-by: Alex Goodman <[email protected]> * use ruby-lang as vendor candidate not target software Signed-off-by: Alex Goodman <[email protected]> * address PR comments for CPE generation Signed-off-by: Alex Goodman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #396
Closes #471