Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Disable docker releases #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2021
Merged

Disable docker releases #493

merged 1 commit into from
Sep 3, 2021

Conversation

@wagoodman
Copy link
Contributor

Currently cannot install docker onto the mac runners in GHA, which we need for signing. The workaround is to disable docker releases for the short-term until we have a fix in place (but we cannot block binary releases on this)

Example infinite loop:
https://github.com/anchore/syft/actions/runs/1199137004

@wagoodman wagoodman requested a review from a team September 3, 2021 21:24
luhring
luhring approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@luhring luhring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@wagoodman wagoodman enabled auto-merge (squash) September 3, 2021 21:26
@github-actions
Copy link

github-actions bot commented Sep 3, 2021

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
name                                                   old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           965µs ± 3%    1086µs ±11%  +12.52%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2        1.51ms ±30%    1.51ms ± 3%     ~     (p=0.730 n=5+4)
ImagePackageCatalogers/javascript-package-cataloger-2     469µs ± 1%     522µs ± 1%  +11.47%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 460µs ± 3%     509µs ± 4%  +10.71%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  482µs ± 1%     570µs ± 3%  +18.18%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  10.2ms ± 0%    11.1ms ± 5%   +9.03%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                  700µs ± 4%     763µs ± 7%   +9.09%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-cataloger-2                     242µs ± 3%     290µs ± 6%  +19.82%  (p=0.008 n=5+5)
ImagePackageCatalogers/rust-cataloger-2                   407µs ± 3%     471µs ± 4%  +15.67%  (p=0.008 n=5+5)

name                                                   old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           133kB ± 0%     133kB ± 0%   +0.21%  (p=0.024 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2         643kB ± 0%     643kB ± 0%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     116kB ± 0%     116kB ± 0%   +0.28%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 126kB ± 0%     127kB ± 0%   +0.25%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  138kB ± 0%     138kB ± 0%   -0.01%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  2.64MB ± 0%    2.64MB ± 0%     ~     (p=0.056 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                 1.16MB ± 0%    1.16MB ± 0%   -0.00%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-cataloger-2                    52.9kB ± 0%    52.9kB ± 0%     ~     (p=0.841 n=5+5)
ImagePackageCatalogers/rust-cataloger-2                   110kB ± 0%     110kB ± 0%   +0.00%  (p=0.008 n=5+5)

name                                                   old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           2.04k ± 0%     2.04k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2         6.14k ± 0%     6.14k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     1.93k ± 0%     1.93k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                 2.41k ± 0%     2.41k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                  3.20k ± 0%     3.20k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                   34.8k ± 0%     34.8k ± 0%     ~     (p=0.079 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                  1.92k ± 0%     1.92k ± 0%     ~     (all equal)
ImagePackageCatalogers/go-cataloger-2                     1.42k ± 0%     1.42k ± 0%     ~     (all equal)
ImagePackageCatalogers/rust-cataloger-2                   2.83k ± 0%     2.83k ± 0%     ~     (all equal)

@wagoodman wagoodman merged commit 06dcd32 into main Sep 3, 2021
@wagoodman wagoodman deleted the disable-docker-releases branch September 3, 2021 21:29
wagoodman added a commit that referenced this pull request Sep 13, 2021
@wagoodman
Revert "disable docker releases (workaround) (#493)"
ca4569f 
This reverts commit 06dcd32.
@wagoodman wagoodman mentioned this pull request Sep 13, 2021
Merged
wagoodman added a commit that referenced this pull request Sep 13, 2021
@wagoodman
Revert "disable docker releases (workaround) (#493)"
1bdc3d4 
This reverts commit 06dcd32.

Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
wagoodman added a commit that referenced this pull request Sep 13, 2021
@wagoodman
Revert "disable docker releases (workaround) (#493)" (#501)
ddfc8e2 
This reverts commit 06dcd32.

Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@wagoodman
disable docker releases (workaround) (anchore#493)
376bb66 
Signed-off-by: Alex Goodman <[email protected]>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@wagoodman
Revert "disable docker releases (workaround) (anchore#493)" (anchore#501
67cef0b 
)

This reverts commit 376bb66.

Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@luhring luhring luhring approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wagoodman @luhring