Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "Disable docker releases" #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2021
Merged

Revert "Disable docker releases" #501

merged 1 commit into from
Sep 13, 2021

Conversation

@wagoodman
Copy link
Contributor

Reverts #493

Testing the docker install process on a fork shows that this issue has been resolved. There is the larger issue of this occurring again in the future --it would be ideal to solve this by removing the dependency on docker-practice/actions-setup-docker@v1 and docker desktop for mac in general. (Migrating to builds via podman + qemu?)

@wagoodman
Revert "disable docker releases (workaround) (#493)"
1bdc3d4 
This reverts commit 06dcd32.

Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
@wagoodman wagoodman force-pushed the revert-493-disable-docker-releases branch from ca4569f to 1bdc3d4 Compare September 13, 2021 16:33
@github-actions
Copy link

github-actions bot commented Sep 13, 2021 •
edited
Loading

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
name                                                   old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           823µs ± 1%     923µs ± 3%  +12.13%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2        1.19ms ± 2%    1.33ms ± 0%  +11.98%  (p=0.029 n=4+4)
ImagePackageCatalogers/javascript-package-cataloger-2     409µs ± 0%     450µs ± 1%  +10.22%  (p=0.016 n=4+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 406µs ± 1%     457µs ± 2%  +12.49%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  426µs ± 1%     457µs ± 3%   +7.32%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  9.18ms ± 1%    9.69ms ± 4%   +5.57%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                  613µs ± 4%     636µs ± 4%     ~     (p=0.095 n=5+5)
ImagePackageCatalogers/go-cataloger-2                     209µs ± 2%     232µs ± 4%  +11.33%  (p=0.008 n=5+5)
ImagePackageCatalogers/rust-cataloger-2                   358µs ± 1%     390µs ± 4%   +8.77%  (p=0.008 n=5+5)

name                                                   old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           133kB ± 0%     133kB ± 0%     ~     (p=0.548 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2         643kB ± 0%     643kB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     116kB ± 0%     116kB ± 0%     ~     (p=0.548 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 126kB ± 0%     126kB ± 0%     ~     (p=0.310 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  138kB ± 0%     138kB ± 0%   +0.01%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  2.64MB ± 0%    2.64MB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                 1.16MB ± 0%    1.16MB ± 0%     ~     (p=0.730 n=5+5)
ImagePackageCatalogers/go-cataloger-2                    52.8kB ± 0%    52.7kB ± 0%   -0.15%  (p=0.008 n=5+5)
ImagePackageCatalogers/rust-cataloger-2                   110kB ± 0%     110kB ± 0%   -0.00%  (p=0.016 n=5+4)

name                                                   old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           2.04k ± 0%     2.04k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2         6.14k ± 0%     6.14k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     1.93k ± 0%     1.93k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                 2.41k ± 0%     2.41k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                  3.20k ± 0%     3.20k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                   34.8k ± 0%     34.8k ± 0%     ~     (p=0.984 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                  1.92k ± 0%     1.92k ± 0%     ~     (all equal)
ImagePackageCatalogers/go-cataloger-2                     1.42k ± 0%     1.42k ± 0%     ~     (all equal)
ImagePackageCatalogers/rust-cataloger-2                   2.83k ± 0%     2.83k ± 0%     ~     (all equal)

@wagoodman wagoodman requested a review from a team September 13, 2021 16:36
kzantow
kzantow approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the comment:

we are having an infinite loop of installing docker

Is this not an issue any more? Fixed in docker-practice/actions-setup-docker@v1?

@wagoodman
Copy link
Contributor Author

wagoodman commented Sep 13, 2021 •
edited
Loading

Good question @kzantow , It looks like it has docker-practice/actions-setup-docker@51fd500 a few days after the problem was noticed on our end. I tried something like this with a different brew formula commit without luck.

@wagoodman wagoodman merged commit ddfc8e2 into main Sep 13, 2021
@wagoodman wagoodman deleted the revert-493-disable-docker-releases branch September 13, 2021 17:06
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@wagoodman
Revert "disable docker releases (workaround) (anchore#493)" (anchore#501
67cef0b 
)

This reverts commit 376bb66.

Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzantow kzantow kzantow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wagoodman @kzantow