Check if there is a progress bar before updating it #340
Conversation
|
@AlbertDeFusco Looks good to me! As the original author of this functionality, are you happy to see this merged? |
|
I suppose my only query is whether there are other error conditions other than the lack of the 'content-length' entry that we should know about (that mean the progress bar isn't created). Either way, this is definitely a more robust fallback. |
|
@jbednar why did you close it? |
|
I think this is a horrible misfeature of GitHub! Jim merged holoviz-topics/examples#187 on |
|
Crazy! Github seems to have decided that because PR 187 on pyviz-topics/examples says "fix" near a reference to this PR, somehow that PR would close this PR. Obviously that's an incorrect inference in this case, but it also seems inappropriate to assume any PR will close another PR. |
|
Thanks for the PR. I'm going to look at getting the tests fixed and merge this. |
the build phase wasn't working becuae the image had upgraded to Python 3.9
|
I've fixed the test and added a changelog. This will be tagged as 0.10.2 |
|
Thanks Albert!
…On Mon, Sep 27, 2021 at 9:05 PM Albert DeFusco ***@***.***> wrote:
I've fixed the test and added a changelog. This will be tagged as 0.10.2
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#340 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AISCWAWJ7KCCWT7WU7URWZ3UEC6AHANCNFSM5END2XCQ>
.
|
Fixes #339
I have seen no existing infrastructure for testing this sort of thing. I tested it on the example reported in the issue and the fix worked fine.