Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Check if there is a progress bar before updating it #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 27, 2021
Merged

Check if there is a progress bar before updating it #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5527fee
check if there is a progress bar
maximlt Sep 21, 2021
83cdf28
use setup-miniconda action
AlbertDeFusco Sep 27, 2021
2caa219
activate env
AlbertDeFusco Sep 27, 2021
7d10620
more action fixes
AlbertDeFusco Sep 27, 2021
29e47a6
try again
AlbertDeFusco Sep 27, 2021
f338e1e
recipe dir
AlbertDeFusco Sep 27, 2021
633c1cf
full path to miniconda3
AlbertDeFusco Sep 27, 2021
66fea14
changelog for 0.10.2
AlbertDeFusco Sep 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,20 @@ jobs:
uses: actions/checkout@v2
with:
fetch-depth: 0
- uses: conda-incubator/setup-miniconda@v2
with:
auto-update-conda: false
miniconda-version: py37_4.10.3
auto-activate-base: true
activate-environment: ""
- name: Install build dependencies
shell: bash -l {0}
run: |
conda config --append channels conda-forge
conda install -y conda-build conda-verify flake8 pep257 yapf==0.30.0 sphinx sphinx_rtd_theme
- name: Verify formatting compliance
shell: bash -l {0}
run: |
source /usr/share/miniconda/bin/activate
if ! yapf --diff --recursive anaconda_project; then
echo "----"
echo "Please run 'yapf --in-place --recursive anaconda_project'"
Expand All @@ -32,19 +39,21 @@ jobs:
flake8 anaconda_project
pep257 anaconda_project
- name: Build the documentation as a test
shell: bash -l {0}
run: |
source /usr/share/miniconda/bin/activate
cd docs
make html
- name: Build the package
run: /usr/share/miniconda/bin/conda build conda.recipe --no-test
shell: bash -l {0}
run: conda build --no-test conda.recipe
- name: Reduce the size of the build artifact
run: rm -rf /usr/share/miniconda/conda-bld/{git_cache,work,anaconda-project*,*/.cache}
shell: bash -l {0}
run: rm -rf ${CONDA}/conda-bld/{git_cache,work,anaconda-project*,*/.cache}
- name: Upload the build artifact
uses: actions/upload-artifact@v2
with:
name: package-${{ github.sha }}
path: /usr/share/miniconda/conda-bld
path: /usr/share/miniconda3/conda-bld
tests:
defaults:
run:
Expand Down
14 changes: 14 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,20 @@

We [keep a changelog.](http://keepachangelog.com/)

## Version 0.10.2

### Bug fixes

* [PR 340](https://github.com/Anaconda-Platform/anaconda-project/pull/340) Fix issue with progress bar


## Version 0.10.1

### Enhancements

* [PR 331](https://github.com/Anaconda-Platform/anaconda-project/pull/331) Add CLI progress bars for project download and extract
* [PR 330](https://github.com/Anaconda-Platform/anaconda-project/pull/330) Add CLI progress bars for data downloads

## Version 0.10.0

### Issues Closed
Expand Down
3 changes: 2 additions & 1 deletion anaconda_project/internal/http_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ def writer(chunk):

try:
_file.write(chunk)
self._progress.update(len(chunk) / 1024 / 1024)
if self._progress is not None:
self._progress.update(len(chunk) / 1024 / 1024)
except EnvironmentError as e:
# we can't actually throw this error or Tornado freaks out, so instead
# we ignore all future chunks once we have an error, which does mean
Expand Down