This repository was archived by the owner on Feb 13, 2024. It is now read-only.
fix the issue that the title bar disappears under multi-window strategy in some specific cases #1810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morphis
suggested changes
May 13, 2021
|
@morphis i think you forgot to merge this one |
|
@morphis hey? |
|
@morphis could you please merge this? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Changes still approved |
|
This PR is one year old now. 🥳 🍰
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybe fix #1184 #928
After some tests, I found that there are two situations cause the vanishment of the title bar.
One of the situation is that the
renderableof the title bar only return the size of the title bar itself (which SHOULD be the whole size of the app). Original algorithm only find the max-sized rectangle and could not handle this situation correctly.And another situation is a little weird. The
renderableof the title bar just vanished without any clue, and the reason of this is beyond my knowledge.This PR only fix the first situation. But the second situation could be easily turned to the first situation by resize the window once.
WARNING: only tested a few APKs and only tested on my laptop with kde, archlinux.
Good Luck