Computation of delta proofs in transactions #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e05b7c7 to
787007f
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the computation of delta proofs in transactions, introducing a structured approach to generating proof witnesses for transaction validation. It refactors the existing transaction system by adding DeltaWitness structures and replacing placeholder delta proof generation with a more systematic approach.
- Introduces
DeltaWitnessandDeltaProofstructures with methods to generate proofs from compliance witnesses - Updates transaction creation across the codebase to generate and use delta witnesses alongside actions
- Refactors universe level handling for
ResourceandComplianceWitnessstructures to improve type safety
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Anoma/Delta.lean | New file defining DeltaWitness structure and proof generation functions |
| Anoma/Transaction.lean | Adds delta proof generation method and imports delta module |
| Anoma/Resource.lean | Updates universe level annotations for type safety |
| Anoma/Compliance.lean | Refactors ComplianceWitness with universe levels and reorders fields |
| AVM/Intent/Translation.lean | Updates intent translation to generate delta witnesses alongside actions |
| AVM/Class/Translation.lean | Refactors action creation to include delta witness generation |
| AVM/Class/Member/Logic.lean | Updates dummy resource creation for universe level compatibility |
Comments suppressed due to low confidence (1)
AVM/Class/Translation.lean:79
- Missing comma after
nfKey := obj.consumed.keyfield assignment.
appData := {
janmasrovira
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deltaProoffields of Transactions, following the general strategy from RISC0 RM.