Computation of nonces #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds explicit nonce support throughout object and resource representations, updates nullifier proof handling, and threads randomness into action creation.
- Introduce
nonce : Option Anoma.NonceonObjectand propagate it intoAnoma.Resourceconversions - Replace
NullifierProofwithCanNullifyResourceand adjustnullifylogic - Thread random nonce generation into compliance units and dummy resources
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Prelude/TypeRep.lean | Added bneq_generic not-equal operator |
| Anoma/Resource.lean | Renamed NullifierProof to CanNullifyResource |
| Anoma/NullifierKey.lean | New NullifierKey and commitment definitions |
| Anoma/Nullifier.lean | Removed duplicate key logic; added Nullifier.toNonce |
| Anoma/Nonce.lean | Defined Nonce alias |
| Anoma/Action.lean | Updated LogicVerifierInput and Action universes |
| AVM/Object/Consumable.lean | Added toResource helper for consumables |
| AVM/Object.lean | Introduced nonce on Object and updated conversion APIs |
| AVM/Intent/Translation.lean | Refactored Intent.action to thread StdGen and nonces |
| AVM/Class/Translation.lean | Refactored Action.create to thread randomness and nonces |
| AVM/Class/Member/Logic.lean | Parameterized dummyResource by nonce; changed dummy filtering |
Comments suppressed due to low confidence (1)
AVM/Class/Translation.lean:22
- [nitpick] The apostrophe in
create'may be unclear. Consider a more descriptive name likecreateWithGenorcreateGento clarify its purpose.
private def Action.create' (g : StdGen) (lab : Label) (memberId : Label.MemberId lab)
Co-authored-by: Copilot <[email protected]>
janmasrovira
approved these changes
Jul 18, 2025
janmasrovira
pushed a commit
that referenced
this pull request
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nonce : Option Anoma.Noncefield toObject. Thenonceis assumed to be available for objects fetched from the system, including allselfobjects.