Simplify AVM.Program implementation #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the AVM Program implementation by removing the Sized variant that tracked program size at the type level and converting the invoke operation from a constructor to a function.
- Removes size tracking from Program types by eliminating
Program.Sizedin favor of directPrograminductive type - Converts
invokefrom an inductive constructor to a standalone function that composes programs - Updates syntax macros to work with the simplified Program structure
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| AVM/Program.lean | Removes Program.Sized type and size tracking, implements invoke as a function |
| Applib/Surface/Program.lean | Updates Program wrapper to use simplified AVM.Program without size tracking |
| Applib/Surface/Program/Syntax.lean | Simplifies macro rules by removing intermediate Ξ syntax and size tracking |
| AVM/Class/Translation.lean | Updates Program.tasks to work with simplified Program structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invokeconstructor and implementing it as a function instead