Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Buzzec
Copy link

@Buzzec Buzzec commented Sep 15, 2025

Optional feature that replaces Pubkey with solana_address::Address. Also adds a feature for solana-pubkey2

@Buzzec Buzzec changed the title Added solana-address feature Added solana-address1 feature Sep 15, 2025
@Buzzec
Copy link
Author

Buzzec commented Sep 15, 2025

This is nice for frameworks that use standard solana libraries like star_frame so that there aren't two different Pubkey types being used and converted between.

@febo
Copy link
Collaborator

febo commented Sep 15, 2025

This is nice for frameworks that use standard solana libraries like star_frame so that there aren't two different Pubkey types being used and converted between.

By coincidence, I am about to finish rebasing #118 which will switch the Pubkey for Address. That one is based on #112 as part of the integration of the SDK types.

Do you see a need to support solana-pubkey 2.*? The plan was to go forward with solana-address.

@Buzzec
Copy link
Author

Buzzec commented Sep 15, 2025

This is nice for frameworks that use standard solana libraries like star_frame so that there aren't two different Pubkey types being used and converted between.

By coincidence, I am about to finish rebasing #118 which will switch the Pubkey for Address. That one is based on #112 as part of the integration of the SDK types.

Do you see a need to support solana-pubkey 2.*? The plan was to go forward with solana-address.

The reason I added it was that star_frame is stuck on that version. @stegaBOB knows specifically why, but I believe a few dependencies haven't updated their solana versions yet

@stegaBOB
Copy link
Contributor

but I believe a few dependencies haven't updated their solana versions yet

Yup this is the reason. Just waiting for mollusk at the moment. That should be released soon I think though so no need to maintain support here

@Buzzec
Copy link
Author

Buzzec commented Sep 16, 2025

Actually we're all updated now so closing this.

@Buzzec Buzzec closed this Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants