Use Address from Solana SDK
#118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2025
662299a to
fd9e12e
Compare
fa49062 to
4100e84
Compare
This was referenced Sep 15, 2025
ea7c848 to
bb588af
Compare
4100e84 to
8077fe8
Compare
b026be9 to
baa8beb
Compare
febo
commented
Sep 21, 2025
Cargo.toml
Outdated
| pinocchio-pubkey = { version = "0.3", path = "sdk/pubkey" } | ||
| quote = "1.0" | ||
| regex = "1" | ||
| solana-address = { version = "1.0", git = "https://github.com/febo/solana-sdk.git", branch = "derive-address" } |
There was a problem hiding this comment.
This will be updated by the published crate once available.
rustopian
approved these changes
Sep 22, 2025
joncinque
reviewed
Sep 26, 2025
|
Update dependency branch to use the |
9d5e409 to
17d0edd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A
Pubkeyis currently being represented as a lightweight alias over a[u8; 32]array. This is different from thePubkeytype on Solana SDK, which makes it confusing to write code that supports both pubkey "types".Solution
Use the new
Addresstype from Solana SDK instead. ThePubkeytype is an alias toAddress, so making this change will result in both pinocchio and SDK to use the same type.This PR also remove the
pinocchio-pubkeycrate, since all the functionality has been added tosolana-address.