address!: Add conditional debug derive #325
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was just thinking about this in the context of #302, and this seems like the easiest path forward. We'll get some confusion if users are outputting pubkeys without the What do you think @vadorovsky? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
Addresstype only includes aDebugimpl when the feature "decode" is enabled, since it includes a base58 formatting. There are cases where it would be useful to have a "default"Debugderive without additional dependencies (e.g.,Addressintegration on pinocchio).Solution
Add a
Debugderive for cases where the feature "decode" is not enabled.