add Signature::as_array #30

fanatid · 2025-02-12T04:20:33Z

It would be nice to have access to the inner array in Signature (same as Pubkey::as_array) to use custom encoder such as five8

joncinque

Makes sense to me, thanks for the contribution! Can you simply add a sanity test similar to the one for Pubkey?

solana-sdk/pubkey/src/lib.rs

Lines 1410 to 1418 in 6afe65a

    
           #[test] 
        
           fn test_as_array() { 
        
               let bytes = [1u8; 32]; 
        
               let key = Pubkey::from(bytes); 
        
               assert_eq!(key.as_array(), &bytes); 
        
               assert_eq!(key.as_array(), &key.to_bytes()); 
        
               // Sanity check: ensure the pointer is the same. 
        
               assert_eq!(key.as_array().as_ptr(), key.0.as_ptr()); 
        
           }

fanatid · 2025-02-28T21:35:54Z

@joncinque updated

joncinque

Looks great, thanks again for the contribution! Sorry for the delay on re-reviewing

* Add unchecked helper * Fix lint * Add inline * Rename to checked * Cosmetics * Fix sol log params

@febo

* Add derive address helpers * Update lock file * Fix doc links * Add missing dependency * Refactor directory structure (#18) * Use macro rules * Update directory structure * Add account info and pubkey helpers (#21) * Rename unchecked methods (#22) * Add map and filter_map to Ref and RefMut (#27) * Add map and filter_map to Ref and RefMut * Add unit tests * Apply suggestions * Add bit flag for original data length (#28) * Add bit flag * Remove declarative macro * Add `checked_create_program_address` helper (#30) * Add unchecked helper * Fix lint * Add inline * Rename to checked * Cosmetics * Fix sol log params * A close macro implementation for AccountInfo (#42) * Added close and based_close * added docs comments + wrapped up and tested both function * cargo clippy and fmt * added the new close and changed the name for * fixed and tested after comments * Fixed Realloc Macro (#45) * Fixed compiler bitching about realloc * Added a better alterantive to the black_box * Fixed latest comments * deleted some line after the refactor * Update comments * Fix last u64 owner index on close (#55) * Fix clippy warnings (#59) * Improve close unchecked * sdk: Improve comments (#64) * [wip]: Add new scripts * [wip]: Use matric strategy * [wip]: Fix members parsing * [wip]: Add CI env variables * [wip]: Remove nothrow * [wip]: Filter changes * [wip]: Add audit step * [wip]: Add semver checks * [wip]: Refactor publish workflow * [wip]: Refactor * [wip]: Fix commands * Fix formatting * Remove detect changes step * Review comments * Fix lint comments * Expand crate comment * Ignore crate comment tests * Add missing docs * More missing docs * Add missing release component * Pin cargo-release version * Fix merge * Review comments * sdk: Lightweight borrow check (#65) * [wip]: Add new scripts * [wip]: Add CI env variables * [wip]: Remove nothrow * [wip]: Filter changes * [wip]: Add audit step * [wip]: Add semver checks * [wip]: Refactor publish workflow * [wip]: Refactor * [wip]: Fix commands * Fix formatting * Remove detect changes step * Add check methods * Use check variant on close * Fix merge * Address review comments (#78) * [wip]: Address review comments * [wip]: Fix pointer reference * [wip]: Add logger buffer size tests * Remove unused * More logger tests * Rename program to cpi * Remove dynamic allocation * Fixed signed tests * Fix review comments * Fix unsigned test case * Add is_owner_by helper * Account borrow state check (#147) * Improve fallback and docs * Add borrow state check * Add inline * Review comments * Revert doc link merge change * Update doc comments on close account (#173) * Update doc comments * Update sdk/pinocchio/src/account_info.rs Co-authored-by: Jon C <[email protected]> * Update sdk/pinocchio/src/account_info.rs Co-authored-by: Jon C <[email protected]> --------- Co-authored-by: Jon C <[email protected]> * Remove *const cast (#170) * Add cargo miri test to CI (#178) * Add miri step * Fix miri issues * Install miri component * Deprecate AccountInfo::realloc (#174) * Add resize * Deprecate realloc * Simplify program entrypoint (#166) * Fix review comments * Revert offset increment change * Add invoke instruction helper * Typos * Remove new helpers * Remove unused * Address review comments * Tweak inline attributes * Use invoke signed unchecked * Refactor inline * Renamed to with_bounds * Update docs * Revert change * Add constant length check * Simplify accounts deserialization * Invert borrow state logic * Use expr instead * Add missing import * Address review comments * Revert unnecessary repr * Fix rebase * Tweak docs * Fix doc reference * Fix miri errors * More review comments * Simplify realloc logic (#175) * Simplify realloc logic * Address review comments * Fix `assign` unsoundness (#180) * Fix assign unsoundness * Remove unsafe * ci: Add spellcheck step (#164) * Add invoke instruction helper * Typos * Remove new helpers * Remove unused * Address review comments * Tweak inline attributes * Use invoke signed unchecked * Refactor inline * Renamed to with_bounds * Update docs * Revert change * Add constant length check * Add spellcheck step * Tweak action * Fix typos * More fixes * Yet more fixes * Fixes * Add j1 option * More and more fixes * Add missing acronym * Fix merge * Fix spelling * Fix spelling * Clarify the use of constant values (#200) * Add comments on constants * Improve offset comments * Add bitmask to dictionary * Renamed to field_at_offset * Ignore `zero_init` parameter (#203) Ignore zero_init parameter * Add resize_unchecked method to account info (#230) * add resize_unchecked method to account info * Apply suggestion from @febo Co-authored-by: Fernando Otero <[email protected]> * Apply suggestion from @febo Co-authored-by: Fernando Otero <[email protected]> * Apply suggestion from @febo Co-authored-by: Fernando Otero <[email protected]> --------- Co-authored-by: Fernando Otero <[email protected]> * Feat: Add debug/copy derives and enable missing debug/copy lint (#228) * Add debug/copy derives and enable missing debug/copy lint * Update sdk/pinocchio/src/sysvars/rent.rs Co-authored-by: Fernando Otero <[email protected]> * Update sdk/pinocchio/src/entrypoint/mod.rs Co-authored-by: Fernando Otero <[email protected]> * Update sdk/pinocchio/src/instruction.rs Co-authored-by: Fernando Otero <[email protected]> * Update sdk/pinocchio/src/sysvars/clock.rs Co-authored-by: Fernando Otero <[email protected]> * Update sdk/pinocchio/src/sysvars/fees.rs * Update sdk/pinocchio/src/sysvars/fees.rs * Update sdk/pinocchio/src/sysvars/instructions.rs Co-authored-by: Fernando Otero <[email protected]> * Update sdk/pinocchio/src/sysvars/instructions.rs Co-authored-by: Fernando Otero <[email protected]> * Update sdk/pinocchio/src/sysvars/instructions.rs Co-authored-by: Fernando Otero <[email protected]> * Update sdk/pinocchio/src/sysvars/clock.rs * Fix syntax error in Instructions struct derive macro --------- Co-authored-by: Fernando Otero <[email protected]> * Feat: make AccountInfo::data_ptr public (#232) * make data_ptr public * Update sdk/pinocchio/src/account_info.rs Co-authored-by: Fernando Otero <[email protected]> * add some tests for data ptr * Fix spelling --------- Co-authored-by: Fernando Otero <[email protected]> * Feat: Add try_maps on AccountInfo Ref/RefMut (#229) * Add try_maps on AccountInfo Ref/RefMut * update tests and api for try map ref * pinocchio: Move `NON_DUP_MARKER` const (#245) Move NON_DUP_MARKER const * chore: fix typo in comment (#240) Signed-off-by: vetclippy <[email protected]> * pinocchio: Add `pubkey_eq` helper (#248) * Add pubkey_eq helper * Fix typo * Update pubkey comparison * Add proptest * Add unlikely * Replace proptest * pinocchio: Add `AccountInfo` invariant details (#254) Add invariant details * Add account view * Improve account borrows * Add constructor * Add account_ptr method * Add copy feature * Add docs configuration * Rename to address * Use clone * Remove unused * Add missing doc_auto_cfg * Fix lints * Add no_std check * Rename account type --------- Signed-off-by: vetclippy <[email protected]> Co-authored-by: Jean Marchand (Exotic Markets) <[email protected]> Co-authored-by: Leonardo Donatacci <[email protected]> Co-authored-by: Dimitris Apostolou <[email protected]> Co-authored-by: Jon C <[email protected]> Co-authored-by: Sammy Harris <[email protected]> Co-authored-by: vetclippy <[email protected]>

* Add unchecked helper * Fix lint * Add inline * Rename to checked * Cosmetics * Fix sol log params

fanatid mentioned this pull request Feb 15, 2025

use five8 in pubkey, signature, hash and keypair crates #33

Merged

add Signature::as_array

066d30f

fanatid force-pushed the sig-as-array branch from 1c2c90b to 066d30f Compare February 22, 2025 00:16

joncinque reviewed Feb 25, 2025

View reviewed changes

add test_as_array

6ee9b6d

fmt

bcbf785

joncinque approved these changes Mar 6, 2025

View reviewed changes

joncinque merged commit b1cdd3c into anza-xyz:master Mar 6, 2025
20 checks passed

fanatid deleted the sig-as-array branch March 7, 2025 12:59

febo added a commit to febo/solana-sdk that referenced this pull request Sep 21, 2025

Add checked_create_program_address helper (anza-xyz#30)

f6db744

* Add unchecked helper * Fix lint * Add inline * Rename to checked * Cosmetics * Fix sol log params

febo added a commit to febo/solana-sdk that referenced this pull request Sep 22, 2025

Add checked_create_program_address helper (anza-xyz#30)

e1de31f

* Add unchecked helper * Fix lint * Add inline * Rename to checked * Cosmetics * Fix sol log params

febo added a commit to febo/solana-sdk that referenced this pull request Sep 22, 2025

Add checked_create_program_address helper (anza-xyz#30)

8a15308

* Add unchecked helper * Fix lint * Add inline * Rename to checked * Cosmetics * Fix sol log params

febo added a commit to febo/solana-sdk that referenced this pull request Sep 24, 2025

Add checked_create_program_address helper (anza-xyz#30)

6fe74f4

* Add unchecked helper * Fix lint * Add inline * Rename to checked * Cosmetics * Fix sol log params

febo added a commit to febo/solana-sdk that referenced this pull request Sep 25, 2025

Add checked_create_program_address helper (anza-xyz#30)

65d3dae

* Add unchecked helper * Fix lint * Add inline * Rename to checked * Cosmetics * Fix sol log params

febo added a commit to febo/solana-sdk that referenced this pull request Oct 2, 2025

Add checked_create_program_address helper (anza-xyz#30)

4b3ebe1

* Add unchecked helper * Fix lint * Add inline * Rename to checked * Cosmetics * Fix sol log params

febo added a commit to febo/solana-sdk that referenced this pull request Oct 2, 2025

Add checked_create_program_address helper (anza-xyz#30)

c61cf44

* Add unchecked helper * Fix lint * Add inline * Rename to checked * Cosmetics * Fix sol log params

febo added a commit to febo/solana-sdk that referenced this pull request Oct 3, 2025

Add checked_create_program_address helper (anza-xyz#30)

ba0b881

* Add unchecked helper * Fix lint * Add inline * Rename to checked * Cosmetics * Fix sol log params

febo added a commit to febo/solana-sdk that referenced this pull request Oct 16, 2025

Add checked_create_program_address helper (anza-xyz#30)

42c45a9

* Add unchecked helper * Fix lint * Add inline * Rename to checked * Cosmetics * Fix sol log params

febo added a commit to febo/solana-sdk that referenced this pull request Oct 17, 2025

Add checked_create_program_address helper (anza-xyz#30)

542de2f

* Add unchecked helper * Fix lint * Add inline * Rename to checked * Cosmetics * Fix sol log params

febo added a commit to febo/solana-sdk that referenced this pull request Oct 18, 2025

Add checked_create_program_address helper (anza-xyz#30)

9492ffa

* Add unchecked helper * Fix lint * Add inline * Rename to checked * Cosmetics * Fix sol log params

febo added a commit to febo/solana-sdk that referenced this pull request Oct 23, 2025

Add checked_create_program_address helper (anza-xyz#30)

530307e

* Add unchecked helper * Fix lint * Add inline * Rename to checked * Cosmetics * Fix sol log params

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

add Signature::as_array #30

add Signature::as_array #30

Uh oh!

fanatid commented Feb 12, 2025

Uh oh!

joncinque left a comment

Uh oh!

fanatid commented Feb 28, 2025

Uh oh!

joncinque left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	#[test]
	fn test_as_array() {
	let bytes = [1u8; 32];
	let key = Pubkey::from(bytes);
	assert_eq!(key.as_array(), &bytes);
	assert_eq!(key.as_array(), &key.to_bytes());
	// Sanity check: ensure the pointer is the same.
	assert_eq!(key.as_array().as_ptr(), key.0.as_ptr());
	}

Uh oh!

add Signature::as_array #30

add Signature::as_array #30

Uh oh!

Conversation

fanatid commented Feb 12, 2025

Uh oh!

joncinque left a comment

Choose a reason for hiding this comment

Uh oh!

fanatid commented Feb 28, 2025

Uh oh!

joncinque left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants