-
Couldn't load subscription status.
- Fork 140
workspace: Relax intra-workspace dependencies #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem All of the crates within solana-sdk pin their dependency on intra-workspace crates, ie `solana-program` uses version `=2.2.0` of `solana-pubkey`. This is a holdover from Agave, where it makes sense to pin everything to be sure that you're getting exactly what you expect. Also, since Agave crates do not always adhere to semver, pinning the local dependencies ensures that the build always works as expected. Since crates are versioned independently within the solana-sdk repo, however, the pinning requires us to publish all downstream crates anytime one of them is updated, to be sure that a build is possible. This is onerous and unnecessary, since solana-sdk will adhere to semver going forward. #### Summary of changes Relax all of the dependencies to remove the `=`. Note that we will need to bump all crates to v2.2.1 and re-publish them so that downstream users can pick up this change, before we can adequately start publishing crates individually.
willhickey
approved these changes
Feb 11, 2025
joncinque
added a commit
to joncinque/solana-sdk
that referenced
this pull request
Feb 12, 2025
#### Problem As mentioned at anza-xyz#27, the sdk crates were pinning their versions internally, which made them more difficult to use outside of the repo. Now that the version has been relaxed, we need to publish these crates, but they're almost all still on v2.2.0. #### Summary of changes Normally crate publishing will be done one-by-one through the GitHub Actions publish workflow, but with ~100 crates, we need to go faster. Bump all of the v2.2.0 crates to v2.2.1, bump address-lookup-table-interface to v2.2.2, and bump loader-v3-interface to v3.0.0 since it contains a breaking change. Once this lands, we can publish all of the crates in the repo.
joncinque
added a commit
to joncinque/solana-sdk
that referenced
this pull request
Feb 12, 2025
#### Problem As mentioned at anza-xyz#27, the sdk crates were pinning their versions internally, which made them more difficult to use outside of the repo. Now that the version has been relaxed, we need to publish these crates, but they're almost all still on v2.2.0. #### Summary of changes Normally crate publishing will be done one-by-one through the GitHub Actions publish workflow, but with ~100 crates, we need to go faster. Bump all of the v2.2.0 crates to v2.2.1, bump address-lookup-table-interface to v2.2.2, and bump loader-v3-interface to v3.0.0 since it contains a breaking change. Once this lands, we can publish all of the crates in the repo.
joncinque
added a commit
that referenced
this pull request
Feb 12, 2025
* workspace: Bump all crates for publish #### Problem As mentioned at #27, the sdk crates were pinning their versions internally, which made them more difficult to use outside of the repo. Now that the version has been relaxed, we need to publish these crates, but they're almost all still on v2.2.0. #### Summary of changes Normally crate publishing will be done one-by-one through the GitHub Actions publish workflow, but with ~100 crates, we need to go faster. Bump all of the v2.2.0 crates to v2.2.1, bump address-lookup-table-interface to v2.2.2, and bump loader-v3-interface to v3.0.0 since it contains a breaking change. Once this lands, we can publish all of the crates in the repo. * Revert cargo.lock changes
joncinque
added a commit
to joncinque/solana
that referenced
this pull request
Feb 13, 2025
#### Problem The SDK relaxed its internal dependencies in anza-xyz/solana-sdk#27, but the monorepo is still using the pinned versions. #### Summary of changes Update all SDK crates to their next version. For almost all of them, that's v2.2.1 Otherwise, the address-lookup-table-interface crates goes to v2.2.2, and the loader-v3-interface goes to v3.0.0 due to a breaking change. To keep this PR small, the logic changes required for v3.0.0 are not implemented, and must be done in follow-up work, which essentially means reapplying the changes from solana-labs#4661.
joncinque
added a commit
to joncinque/solana
that referenced
this pull request
Feb 13, 2025
#### Problem The SDK relaxed its internal dependencies in anza-xyz/solana-sdk#27, but the monorepo is still using the pinned versions. #### Summary of changes Update all SDK crates to their next version. For almost all of them, that's v2.2.1 Otherwise, the address-lookup-table-interface crates goes to v2.2.2, and the loader-v3-interface goes to v3.0.0 due to a breaking change. To keep this PR small, the logic changes required for v3.0.0 are not implemented, and must be done in follow-up work, which essentially means reapplying the changes from solana-labs#4661.
mergify bot
pushed a commit
to anza-xyz/agave
that referenced
this pull request
Feb 13, 2025
* sdk: Bump all SDK crates for relaxed dependencies #### Problem The SDK relaxed its internal dependencies in anza-xyz/solana-sdk#27, but the monorepo is still using the pinned versions. #### Summary of changes Update all SDK crates to their next version. For almost all of them, that's v2.2.1 Otherwise, the address-lookup-table-interface crates goes to v2.2.2, and the loader-v3-interface goes to v3.0.0 due to a breaking change. To keep this PR small, the logic changes required for v3.0.0 are not implemented, and must be done in follow-up work, which essentially means reapplying the changes from #4661. * Return errors instead of panicking
mergify bot
pushed a commit
to anza-xyz/agave
that referenced
this pull request
Feb 13, 2025
* sdk: Bump all SDK crates for relaxed dependencies #### Problem The SDK relaxed its internal dependencies in anza-xyz/solana-sdk#27, but the monorepo is still using the pinned versions. #### Summary of changes Update all SDK crates to their next version. For almost all of them, that's v2.2.1 Otherwise, the address-lookup-table-interface crates goes to v2.2.2, and the loader-v3-interface goes to v3.0.0 due to a breaking change. To keep this PR small, the logic changes required for v3.0.0 are not implemented, and must be done in follow-up work, which essentially means reapplying the changes from #4661. * Return errors instead of panicking (cherry picked from commit a1ed2b1)
joncinque
added a commit
to anza-xyz/agave
that referenced
this pull request
Feb 13, 2025
* sdk: Bump all SDK crates for relaxed dependencies #### Problem The SDK relaxed its internal dependencies in anza-xyz/solana-sdk#27, but the monorepo is still using the pinned versions. #### Summary of changes Update all SDK crates to their next version. For almost all of them, that's v2.2.1 Otherwise, the address-lookup-table-interface crates goes to v2.2.2, and the loader-v3-interface goes to v3.0.0 due to a breaking change. To keep this PR small, the logic changes required for v3.0.0 are not implemented, and must be done in follow-up work, which essentially means reapplying the changes from #4661. * Return errors instead of panicking (cherry picked from commit a1ed2b1)
Lichtso
pushed a commit
to anza-xyz/agave
that referenced
this pull request
Feb 14, 2025
…4969) (#4972) sdk: Bump all SDK crates for relaxed dependencies (#4969) * sdk: Bump all SDK crates for relaxed dependencies #### Problem The SDK relaxed its internal dependencies in anza-xyz/solana-sdk#27, but the monorepo is still using the pinned versions. #### Summary of changes Update all SDK crates to their next version. For almost all of them, that's v2.2.1 Otherwise, the address-lookup-table-interface crates goes to v2.2.2, and the loader-v3-interface goes to v3.0.0 due to a breaking change. To keep this PR small, the logic changes required for v3.0.0 are not implemented, and must be done in follow-up work, which essentially means reapplying the changes from #4661. * Return errors instead of panicking (cherry picked from commit a1ed2b1) Co-authored-by: Jon C <[email protected]>
febo
pushed a commit
to febo/solana-sdk
that referenced
this pull request
Sep 21, 2025
* Add map and filter_map to Ref and RefMut * Add unit tests * Apply suggestions
febo
pushed a commit
to febo/solana-sdk
that referenced
this pull request
Sep 22, 2025
* Add map and filter_map to Ref and RefMut * Add unit tests * Apply suggestions
febo
pushed a commit
to febo/solana-sdk
that referenced
this pull request
Sep 22, 2025
* Add map and filter_map to Ref and RefMut * Add unit tests * Apply suggestions
febo
pushed a commit
to febo/solana-sdk
that referenced
this pull request
Oct 2, 2025
* Add map and filter_map to Ref and RefMut * Add unit tests * Apply suggestions
febo
pushed a commit
to febo/solana-sdk
that referenced
this pull request
Oct 2, 2025
* Add map and filter_map to Ref and RefMut * Add unit tests * Apply suggestions
febo
pushed a commit
to febo/solana-sdk
that referenced
this pull request
Oct 16, 2025
* Add map and filter_map to Ref and RefMut * Add unit tests * Apply suggestions
febo
pushed a commit
to febo/solana-sdk
that referenced
this pull request
Oct 17, 2025
* Add map and filter_map to Ref and RefMut * Add unit tests * Apply suggestions
febo
added a commit
that referenced
this pull request
Oct 23, 2025
* Add derive address helpers * Update lock file * Fix doc links * Add missing dependency * Refactor directory structure (#18) * Use macro rules * Update directory structure * Add account info and pubkey helpers (#21) * Rename unchecked methods (#22) * Add map and filter_map to Ref and RefMut (#27) * Add map and filter_map to Ref and RefMut * Add unit tests * Apply suggestions * Add bit flag for original data length (#28) * Add bit flag * Remove declarative macro * Add `checked_create_program_address` helper (#30) * Add unchecked helper * Fix lint * Add inline * Rename to checked * Cosmetics * Fix sol log params * A close macro implementation for AccountInfo (#42) * Added close and based_close * added docs comments + wrapped up and tested both function * cargo clippy and fmt * added the new close and changed the name for * fixed and tested after comments * Fixed Realloc Macro (#45) * Fixed compiler bitching about realloc * Added a better alterantive to the black_box * Fixed latest comments * deleted some line after the refactor * Update comments * Fix last u64 owner index on close (#55) * Fix clippy warnings (#59) * Improve close unchecked * sdk: Improve comments (#64) * [wip]: Add new scripts * [wip]: Use matric strategy * [wip]: Fix members parsing * [wip]: Add CI env variables * [wip]: Remove nothrow * [wip]: Filter changes * [wip]: Add audit step * [wip]: Add semver checks * [wip]: Refactor publish workflow * [wip]: Refactor * [wip]: Fix commands * Fix formatting * Remove detect changes step * Review comments * Fix lint comments * Expand crate comment * Ignore crate comment tests * Add missing docs * More missing docs * Add missing release component * Pin cargo-release version * Fix merge * Review comments * sdk: Lightweight borrow check (#65) * [wip]: Add new scripts * [wip]: Add CI env variables * [wip]: Remove nothrow * [wip]: Filter changes * [wip]: Add audit step * [wip]: Add semver checks * [wip]: Refactor publish workflow * [wip]: Refactor * [wip]: Fix commands * Fix formatting * Remove detect changes step * Add check methods * Use check variant on close * Fix merge * Address review comments (#78) * [wip]: Address review comments * [wip]: Fix pointer reference * [wip]: Add logger buffer size tests * Remove unused * More logger tests * Rename program to cpi * Remove dynamic allocation * Fixed signed tests * Fix review comments * Fix unsigned test case * Add is_owner_by helper * Account borrow state check (#147) * Improve fallback and docs * Add borrow state check * Add inline * Review comments * Revert doc link merge change * Update doc comments on close account (#173) * Update doc comments * Update sdk/pinocchio/src/account_info.rs Co-authored-by: Jon C <[email protected]> * Update sdk/pinocchio/src/account_info.rs Co-authored-by: Jon C <[email protected]> --------- Co-authored-by: Jon C <[email protected]> * Remove *const cast (#170) * Add cargo miri test to CI (#178) * Add miri step * Fix miri issues * Install miri component * Deprecate AccountInfo::realloc (#174) * Add resize * Deprecate realloc * Simplify program entrypoint (#166) * Fix review comments * Revert offset increment change * Add invoke instruction helper * Typos * Remove new helpers * Remove unused * Address review comments * Tweak inline attributes * Use invoke signed unchecked * Refactor inline * Renamed to with_bounds * Update docs * Revert change * Add constant length check * Simplify accounts deserialization * Invert borrow state logic * Use expr instead * Add missing import * Address review comments * Revert unnecessary repr * Fix rebase * Tweak docs * Fix doc reference * Fix miri errors * More review comments * Simplify realloc logic (#175) * Simplify realloc logic * Address review comments * Fix `assign` unsoundness (#180) * Fix assign unsoundness * Remove unsafe * ci: Add spellcheck step (#164) * Add invoke instruction helper * Typos * Remove new helpers * Remove unused * Address review comments * Tweak inline attributes * Use invoke signed unchecked * Refactor inline * Renamed to with_bounds * Update docs * Revert change * Add constant length check * Add spellcheck step * Tweak action * Fix typos * More fixes * Yet more fixes * Fixes * Add j1 option * More and more fixes * Add missing acronym * Fix merge * Fix spelling * Fix spelling * Clarify the use of constant values (#200) * Add comments on constants * Improve offset comments * Add bitmask to dictionary * Renamed to field_at_offset * Ignore `zero_init` parameter (#203) Ignore zero_init parameter * Add resize_unchecked method to account info (#230) * add resize_unchecked method to account info * Apply suggestion from @febo Co-authored-by: Fernando Otero <[email protected]> * Apply suggestion from @febo Co-authored-by: Fernando Otero <[email protected]> * Apply suggestion from @febo Co-authored-by: Fernando Otero <[email protected]> --------- Co-authored-by: Fernando Otero <[email protected]> * Feat: Add debug/copy derives and enable missing debug/copy lint (#228) * Add debug/copy derives and enable missing debug/copy lint * Update sdk/pinocchio/src/sysvars/rent.rs Co-authored-by: Fernando Otero <[email protected]> * Update sdk/pinocchio/src/entrypoint/mod.rs Co-authored-by: Fernando Otero <[email protected]> * Update sdk/pinocchio/src/instruction.rs Co-authored-by: Fernando Otero <[email protected]> * Update sdk/pinocchio/src/sysvars/clock.rs Co-authored-by: Fernando Otero <[email protected]> * Update sdk/pinocchio/src/sysvars/fees.rs * Update sdk/pinocchio/src/sysvars/fees.rs * Update sdk/pinocchio/src/sysvars/instructions.rs Co-authored-by: Fernando Otero <[email protected]> * Update sdk/pinocchio/src/sysvars/instructions.rs Co-authored-by: Fernando Otero <[email protected]> * Update sdk/pinocchio/src/sysvars/instructions.rs Co-authored-by: Fernando Otero <[email protected]> * Update sdk/pinocchio/src/sysvars/clock.rs * Fix syntax error in Instructions struct derive macro --------- Co-authored-by: Fernando Otero <[email protected]> * Feat: make AccountInfo::data_ptr public (#232) * make data_ptr public * Update sdk/pinocchio/src/account_info.rs Co-authored-by: Fernando Otero <[email protected]> * add some tests for data ptr * Fix spelling --------- Co-authored-by: Fernando Otero <[email protected]> * Feat: Add try_maps on AccountInfo Ref/RefMut (#229) * Add try_maps on AccountInfo Ref/RefMut * update tests and api for try map ref * pinocchio: Move `NON_DUP_MARKER` const (#245) Move NON_DUP_MARKER const * chore: fix typo in comment (#240) Signed-off-by: vetclippy <[email protected]> * pinocchio: Add `pubkey_eq` helper (#248) * Add pubkey_eq helper * Fix typo * Update pubkey comparison * Add proptest * Add unlikely * Replace proptest * pinocchio: Add `AccountInfo` invariant details (#254) Add invariant details * Add account view * Improve account borrows * Add constructor * Add account_ptr method * Add copy feature * Add docs configuration * Rename to address * Use clone * Remove unused * Add missing doc_auto_cfg * Fix lints * Add no_std check * Rename account type --------- Signed-off-by: vetclippy <[email protected]> Co-authored-by: Jean Marchand (Exotic Markets) <[email protected]> Co-authored-by: Leonardo Donatacci <[email protected]> Co-authored-by: Dimitris Apostolou <[email protected]> Co-authored-by: Jon C <[email protected]> Co-authored-by: Sammy Harris <[email protected]> Co-authored-by: vetclippy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
All of the crates within solana-sdk pin their dependency on intra-workspace crates, ie
solana-programuses version=2.2.0ofsolana-pubkey. This is a holdover from Agave, where it makes sense to pin everything to be sure that you're getting exactly what you expect.Also, since Agave crates do not always adhere to semver, pinning the local dependencies ensures that the build always works as expected.
Since crates are versioned independently within the solana-sdk repo, however, the pinning requires us to publish all downstream crates anytime one of them is updated, to be sure that a build is possible. This is onerous and unnecessary, since solana-sdk will adhere to semver going forward.
Summary of changes
Relax all of the dependencies to remove the
=.Note that we will need to bump all crates to v2.2.1 and re-publish them so that downstream users can pick up this change, before we can adequately start publishing crates individually.