Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@joncinque
Copy link
Collaborator

Problem

As mentioned at #27, the sdk crates were pinning their versions internally, which made them more difficult to use outside of the repo. Now that the version has been relaxed, we need to publish these crates, but they're almost all still on v2.2.0.

Summary of changes

Normally crate publishing will be done one-by-one through the GitHub Actions publish workflow, but with ~100 crates, we need to go faster.

Bump all of the v2.2.0 crates to v2.2.1, bump address-lookup-table-interface to v2.2.2, and bump loader-v3-interface to v3.0.0 since it contains a breaking change.

Once this lands, we can publish all of the crates in the repo.

@joncinque joncinque requested a review from willhickey February 12, 2025 17:02
@joncinque
Copy link
Collaborator Author

joncinque commented Feb 12, 2025

CI error will be fixed with #32 rebased!

#### Problem

As mentioned at anza-xyz#27, the sdk crates were pinning their versions
internally, which made them more difficult to use outside of the repo.
Now that the version has been relaxed, we need to publish these crates,
but they're almost all still on v2.2.0.

#### Summary of changes

Normally crate publishing will be done one-by-one through the GitHub
Actions publish workflow, but with ~100 crates, we need to go faster.

Bump all of the v2.2.0 crates to v2.2.1, bump
address-lookup-table-interface to v2.2.2, and bump loader-v3-interface
to v3.0.0 since it contains a breaking change.

Once this lands, we can publish all of the crates in the repo.
willhickey
willhickey previously approved these changes Feb 12, 2025
Copy link
Contributor

@willhickey willhickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the windows-sys dependency version changes everything is how I would expect it.

Cargo.lock Outdated
"hermit-abi 0.4.0",
"libc",
"windows-sys 0.59.0",
"windows-sys 0.52.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change expected? There's a similar one at line 4651

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit surprised by those changes too.

I reverted them manually, and it doesn't look like cargo tries to downgrade it again, so committed up 97e3f6e -- thanks for noticing!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah cargo does something weird. We never did figure out the borsh dependency version change that was happening in the monorepo. Chido eventually added a step to the version bump that just manually reverts it 🙈

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes, that's rough 😅

@joncinque joncinque enabled auto-merge (squash) February 12, 2025 19:23
@joncinque joncinque merged commit 1c1d667 into anza-xyz:master Feb 12, 2025
20 checks passed
@joncinque joncinque deleted the bumps branch February 12, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants