SIMD-0334: Fix alt_bn128_pairing syscall length check #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clippy gives error only for |
|
I fixed everywhere. It looks like clippy does not see code inside |
| .checked_rem(ALT_BN128_PAIRING_ELEMENT_SIZE) | ||
| .is_none() | ||
| { | ||
| if input.len() % ALT_BN128_PAIRING_ELEMENT_SIZE != 0 { |
There was a problem hiding this comment.
Let's change this to the clippy style as was done in alt_bn128_versioned_pairing.
There was a problem hiding this comment.
This is what I did at first, but CI failed because is_multiple_of is unstable feature in sbf compiler.
There was a problem hiding this comment.
Oh I see. Sorry, I was also wondering why you reverted there. I think the changes are good as is then.
| .checked_rem(ALT_BN128_PAIRING_ELEMENT_SIZE) | ||
| .is_none() | ||
| { | ||
| if input.len() % ALT_BN128_PAIRING_ELEMENT_SIZE != 0 { |
samkim-crypto
approved these changes
Sep 22, 2025
This was referenced Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented SDK changes for SIMD-0334