[bn254] Revert breaking change on alt_bn128_pairing
#399
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecf9684 to
c38071d
Compare
c38071d to
d29b569
Compare
joncinque
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#324 implemented changes for SIMD-334. However, it introduced a breaking change to the existing
alt_bn128_pairingfunction. This function is deprecated since v3.1, but previously, this function defined the behavior of the syscall function in the validator logic, so we should be careful with making breaking changes.Summary of Changes
Revert back the behavior of
alt_bn128_pairingfunction to its original behavior. I copied code of thealt_bn128_pairingfunction from #297, which was before we published v3.1.