Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

JiriProkop
Copy link

Description

This PR introduces a new configuration property:
cas.authn.oidc.registration.dynamic-client-registration-enabled: true

By default, OIDC dynamic client registration (/cas/oidc/register) is still on. Setting this property to false disables all the dynamic registration endpoints.

  • Brief description of changes applied
  • Test cases for all modified changes, where applicable
  • The same pull request targeted at the master branch, if applicable
  • Any documentation on how to configure, test
  • Any possible limitations, side effects, etc
  • Reference any other pull requests that might be related

Copy link
Member

@mmoayyed mmoayyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all NoOp functionality you have added and simply add the check to the real controllers. Make sure you have test cases for all controllers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants