feat: dynamic registration of oidc services can be turned off #7819
+183
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmoayyed
requested changes
Oct 21, 2025
Member
mmoayyed
left a comment
There was a problem hiding this comment.
Please remove all NoOp functionality you have added and simply add the check to the real controllers. Make sure you have test cases for all controllers.
54f2e75 to
ae153e7
Compare
Author
Done. Do you think it's ok like this? I just need to turn off this way to register services but not 100% sure whether I blocked all/only the relevant endpoints. |
Member
|
It looks very good, thank you. I'll take a more thorough pass in the next few days but I think we should be pretty much ready to merge this. |
43c0b53 to
81b9210
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new configuration property:
cas.authn.oidc.registration.dynamic-client-registration-enabled: true
By default, OIDC dynamic client registration (/cas/oidc/register) is still on. Setting this property to false disables all the dynamic registration endpoints.