Modest updates to README.md because 1.0 already happened #143
Conversation
README.md
Outdated
| ### Why was this fork created? | ||
|
|
||
| The original Bats repository needed new maintainers, and has not been actively | ||
| The original Bats repository needed new maintainers, and had not been actively |
There was a problem hiding this comment.
I would recommend dropping this particular change. This adjustment to wording makes it sound like the original bats project is being actively maintained by the original maintainer again, when that is not the case.
There was a problem hiding this comment.
Although it's written in the past tense and sounds clear enough IMHO, perhaps "is no longer maintained" would dispel any ambiguity.
|
Generally sounds good to me. If you wouldn't mind making that one change @rfay I'll merge. Thanks 🙏 |
43d86cb to
9b2a1d3
Compare
|
Simplified to "The original Bats repository is no longer maintained and write access to it could not be obtained. This fork allowed ongoing maintenance and forward progress for Bats". Hope that works. |
|
LGTM, thanks for the changes @rfay 👍 |
| [bats-orig]: https://github.com/sstephenson/bats | ||
| [0360811]: https://github.com/sstephenson/bats/commit/03608115df2071fff4eaaff1605768c275e5f81f | ||
|
|
||
| This [bats-core repo](https://github.com/bats-core/bats-core) is now the official Bats project. |
There was a problem hiding this comment.
I'm not sure anyone is in the position of claiming which project is "official" other than Sam himself. I think we should reword this to indicate it's the main community project or something?
| if or when the need arises | ||
| 1. Prevents lock-out by giving administrative access to more than one person, | ||
| increases transferability | ||
| The original Bats repository is no longer maintained and write access to it could not be obtained. This fork allowed ongoing maintenance and forward progress for Bats. |
There was a problem hiding this comment.
I'm also a little wary of the phrasing "is no longer maintained"... Again, there's a fine distinction between a project officially declared unmaintained by the owner, and one appearing unmaintained from the outside.
Bats upstream is definitely the latter, but only questionably the former. I think we can word this better to be unambiguous without simply declaring the status of upstream by fiat.
There was a problem hiding this comment.
Good point, I'd agree with this.
Tweaked some wording after #143
Tweaked some wording after #143
This PR just updates the README.md a bit based on the current status of the project. v1.0 happened some time ago, etc.