-
Notifications
You must be signed in to change notification settings - Fork 455
Tweaks to readme #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaks to readme #185
Conversation
Tweaked some wording after #143
README.md
Outdated
| ### Why was this fork created? | ||
|
|
||
| The original Bats repository is no longer maintained and write access to it could not be obtained. This fork allowed ongoing maintenance and forward progress for Bats. | ||
| There was an initial [call for maintainers][call-maintain] for the original Bats repository, but write access to it could not be obtained. As the main repository appeared inactive, this fork allowed ongoing maintenance and forward progress for Bats. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. I didn't realize the call-maintain link wasn't in this section.
I like the general wording. The only thing is that I think people browsing on GitHub might conflate the code repository with the GitHub repository as a whole, so they might get the opposite perception that the GitHub repo is inactive (which is not true of course, there are a lot of PRs and discussion).
Also: Do you think it's worth noting the timespan? I tend to lean towards being too detailed so feel free to disregard if you don't think that's necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meh. with both the link to the original call for maintainers and the link to the issue documenting the fork, those interested can derive the time allowed.
But I agree with the repo phrasing. will tweak a bit more.
|
Clarifications look good 👍 |
Tweaked some wording after #143
I had a few concerns with the original wording, now addressed.
This PR should be squash-merged once approved.