Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jasonkarns
Copy link
Member

@jasonkarns jasonkarns commented Feb 18, 2019

Tweaked some wording after #143

I had a few concerns with the original wording, now addressed.

This PR should be squash-merged once approved.

jasonkarns and others added 2 commits February 18, 2019 13:20
@ghost ghost assigned jasonkarns Feb 18, 2019
@ghost ghost added the review label Feb 18, 2019
@jasonkarns jasonkarns marked this pull request as ready for review February 18, 2019 18:22
@jasonkarns jasonkarns requested a review from a team as a code owner February 18, 2019 18:22
README.md Outdated
### Why was this fork created?

The original Bats repository is no longer maintained and write access to it could not be obtained. This fork allowed ongoing maintenance and forward progress for Bats.
There was an initial [call for maintainers][call-maintain] for the original Bats repository, but write access to it could not be obtained. As the main repository appeared inactive, this fork allowed ongoing maintenance and forward progress for Bats.
Copy link
Member

@btamayo btamayo Feb 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I didn't realize the call-maintain link wasn't in this section.

I like the general wording. The only thing is that I think people browsing on GitHub might conflate the code repository with the GitHub repository as a whole, so they might get the opposite perception that the GitHub repo is inactive (which is not true of course, there are a lot of PRs and discussion).

Also: Do you think it's worth noting the timespan? I tend to lean towards being too detailed so feel free to disregard if you don't think that's necessary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh. with both the link to the original call for maintainers and the link to the issue documenting the fork, those interested can derive the time allowed.

But I agree with the repo phrasing. will tweak a bit more.

@sublimino
Copy link
Member

Clarifications look good 👍

@jasonkarns jasonkarns merged commit 0cd82db into master Feb 19, 2019
@jasonkarns jasonkarns deleted the readme branch February 19, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants