Thanks to visit codestin.com
Credit goes to github.com

Skip to content

UI bug fixes #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2024
Merged

UI bug fixes #188

merged 1 commit into from
Apr 30, 2024

Conversation

@TimCsaky
Copy link
Contributor

@TimCsaky TimCsaky commented Apr 30, 2024

  • add visual indicator for focus on topnav and footer
  • update primevue
  • fix treetable expanded rows
  • eslint fix for type error

NOTE: The BC Gov style guide requires color: #2378c7 for focus indicator
But the theme we are using in BCBox uses #a6d5fa for focus on all elements
Overriding this for all the primevue components seems to be a big task (they dont use variables for this)
So until we do that work.. we can either

  1. keep consistent with primevue theme.
    OR
  2. only have #2378c7 for our plain anchor elements
    I went for option 1

Description

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions
Copy link

github-actions bot commented Apr 30, 2024

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Apr 30, 2024 •
edited
Loading

Code Climate has analyzed commit d6c3f34 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 24.5% (0.0% change).

View more on Code Climate.

@TimCsaky TimCsaky requested review from jatindersingh93 and norrisng-bc and removed request for jatindersingh93 and norrisng-bc April 30, 2024 20:14
@github-actions
Copy link

github-actions bot commented Apr 30, 2024 •
edited
Loading

Coverage Report (Frontend)

Totals Coverage
Statements: 19.33% ( 699 / 3616 )
Methods: 18.5% ( 133 / 719 )
Lines: 23.21% ( 487 / 2098 )
Branches: 9.89% ( 79 / 799 )

@TimCsaky
UI bug fixes
d6c3f34 
add visual indicator for focus on topnav and footer
update primevue
fix treetable expanded rows
eslint fix
@jatindersingh93 jatindersingh93 merged commit 4b5f307 into master Apr 30, 2024
@TimCsaky TimCsaky deleted the chore/nav-access branch May 1, 2024 22:37
@norrisng-bc norrisng-bc mentioned this pull request May 2, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jatindersingh93 jatindersingh93 jatindersingh93 approved these changes

@norrisng-bc norrisng-bc norrisng-bc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TimCsaky @jatindersingh93 @norrisng-bc