Fix object share button aria-label #192
Conversation
Coverage Report (Application)
|
|
Code Climate has analyzed commit b9257b9 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 24.5% (0.0% change). View more on Code Climate. |
Coverage Report (Frontend)
|
| v-tooltip.bottom="`${props.labelText} Share`" | ||
| class="p-button-lg p-button-text primary" | ||
| aria-label="`${props.labelText} Share`" | ||
| aria-label="Object share" |
There was a problem hiding this comment.
I think the purpose was to keep this label dynamic text, it will break AriaLabel for bucket share button, I will do some further review while doing screen reader testing.
There was a problem hiding this comment.
The tooltip text isn't dynamic, no?
The screen reader (at least on macOS) will read "props dot label text" with the original aria-label.
There was a problem hiding this comment.
:aria-label="${props.labelText} share" might work
35b4561 to
b9257b9
Compare
Description
This fixes the
aria-labelfor the "object share" button for objects, so that screen readers can correctly read the button.There were no issues with the visible tooltip.
https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3653
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments
Much of the heavy lifting for this ticket seems to have been already done in SHOWCASE-3656 and SHOWCASE-3657 (and possibly SHOWCASE-3515, when Primevue got updated to 3.52)