refactor(cli/logging): removed duplication in setup_cli_subscriber(...) #7531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jad K. Haddad <[email protected]>
|
ematipico
reviewed
Sep 18, 2025
Member
ematipico
left a comment
There was a problem hiding this comment.
That's an improvement! Thank you! Left some suggestions
…rExt Signed-off-by: Jad K. Haddad <[email protected]>
Signed-off-by: Jad K. Haddad <[email protected]>
Signed-off-by: Jad K. Haddad <[email protected]>
cd949b9 to
1cec003
Compare
…r_else_test` Signed-off-by: Jad K. Haddad <[email protected]>
ematipico
approved these changes
Nov 11, 2025
ematipico
pushed a commit
to hamirmahal/biome
that referenced
this pull request
Nov 19, 2025
Contributor
|
FYI, this disabled all logging because the |
cormacrelf
added a commit
to cormacrelf/biome
that referenced
this pull request
Nov 24, 2025
That PR completely disabled logging because you can't just `impl Layer` without forwarding any of the 600 million methods.
cormacrelf
added a commit
to cormacrelf/biome
that referenced
this pull request
Nov 25, 2025
That PR completely disabled logging because you can't just `impl Layer` without forwarding any of the 600 million methods.
cormacrelf
added a commit
to cormacrelf/biome
that referenced
this pull request
Nov 25, 2025
That PR completely disabled logging because you can't just `impl Layer` without forwarding any of the 600 million methods.
Contributor
Author
|
@cormacrelf thanks |
dyc3
added a commit
that referenced
this pull request
Nov 25, 2025
Co-authored-by: Emanuele Stoppa <[email protected]> Co-authored-by: Carson McManus <[email protected]>
l0ngvh
pushed a commit
to l0ngvh/biome
that referenced
this pull request
Dec 21, 2025
l0ngvh
pushed a commit
to l0ngvh/biome
that referenced
this pull request
Dec 21, 2025
…s#8256) Co-authored-by: Emanuele Stoppa <[email protected]> Co-authored-by: Carson McManus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes ugly code (generic swamp) in crates/biome_cli/src/logging.rs
Test Plan
I did not find any tests for
setup_cli_subscriber. I would like to get some information on how to test the old implementation, so I can write the tests and test the new one.