fix(cli): revert some of PR #7531 to re-enable logging #8256

cormacrelf · 2025-11-25T11:00:09Z

PR #7531 completely disabled logging because you can't just impl Layer without forwarding any of the 600 million methods.

Summary

The motivation for making this change is that I wanted to see the logs

Test Plan

None

Docs

The logs are already documented to be working. They just weren't working

That PR completely disabled logging because you can't just `impl Layer` without forwarding any of the 600 million methods.

changeset-bot · 2025-11-25T11:00:14Z

🦋 Changeset detected

Latest commit: a41a32c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-11-25T11:02:22Z

Walkthrough

Refactors setup_cli_subscriber to build a registry and compute a filter, then applies the filter inline per output variant (Pretty, Compact, Json). Removes the OrderedVariants<First,Second,Third> enum, the OrderedVariantsExt trait and its blanket impl, and the multi-variant layering machinery. Adjusts tracing_subscriber_ext imports and keeps OptionMakeWriter / its optional extension and tests; Json retains flatten_event(true). No exported/public declarations were added.

Possibly related PRs

fix(cli): pretty logger #7264: Also modifies crates/biome_cli/src/logging.rs, changing how the Pretty logging branch is constructed and filtered.

Suggested reviewers

siketyan
Netail

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: reverting part of a previous PR to re-enable logging functionality.
Description check	✅ Passed	The description relates to the changeset by explaining the regression (logging disabled) and the fix (revert some changes from PR #7531).

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fb296b8 and a41a32c.

📒 Files selected for processing (1)

.changeset/cold-webs-vanish.md (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/.changeset/*.md

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Changeset descriptions should be user-facing, use past tense for actions taken (e.g., 'Added new feature'), and present tense for Biome behavior (e.g., 'Biome now supports...'). Include issue links, rule links, and code examples where applicable.

Files:

.changeset/cold-webs-vanish.md

🧠 Learnings (2)

📚 Learning: 2025-11-24T18:03:52.014Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:03:52.014Z
Learning: For bugfix/feature PRs visible to Biome toolchain users or affecting published crates, create a changeset using the `just new-changeset` command with appropriate package selection, change type (major/minor/patch), and description.

Applied to files:

.changeset/cold-webs-vanish.md

📚 Learning: 2025-11-24T18:03:52.013Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:03:52.013Z
Learning: Applies to **/.changeset/*.md : Changeset descriptions should be user-facing, use past tense for actions taken (e.g., 'Added new feature'), and present tense for Biome behavior (e.g., 'Biome now supports...'). Include issue links, rule links, and code examples where applicable.

Applied to files:

.changeset/cold-webs-vanish.md

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

GitHub Check: Documentation
GitHub Check: Test (depot-ubuntu-24.04-arm-16)
GitHub Check: Lint project (depot-windows-2022)
GitHub Check: End-to-end tests
GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
GitHub Check: Check Dependencies
GitHub Check: Test (depot-windows-2022-16)
GitHub Check: Test Node.js API
GitHub Check: autofix

🔇 Additional comments (1)

.changeset/cold-webs-vanish.md (1)

1-5: Looks good!

The changeset is user-facing, uses appropriate past tense, and clearly describes the regression fix. The frontmatter is correct and trailing whitespace has already been addressed.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

Provide your own instructions using the high_level_summary_instructions setting.
Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

📝 Description — Summarize the main change in 50–60 words, explaining what was done.

📓 References — List relevant issues, discussions, documentation, or related PRs.

📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.

📊 Contributor Summary — Include a Markdown table showing contributions:
| Contributor | Lines Added | Lines Removed | Files Changed |

✔️ Additional Notes — Add any extra reviewer context.
Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

ematipico

Thank you for catching this!

.changeset/cold-webs-vanish.md

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c29c8e5 and fb296b8.

📒 Files selected for processing (1)

.changeset/cold-webs-vanish.md (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/.changeset/*.md

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Changeset descriptions should be user-facing, use past tense for actions taken (e.g., 'Added new feature'), and present tense for Biome behavior (e.g., 'Biome now supports...'). Include issue links, rule links, and code examples where applicable.

Files:

.changeset/cold-webs-vanish.md

🧠 Learnings (3)

📚 Learning: 2025-11-24T18:03:52.014Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:03:52.014Z
Learning: For bugfix/feature PRs visible to Biome toolchain users or affecting published crates, create a changeset using the `just new-changeset` command with appropriate package selection, change type (major/minor/patch), and description.

Applied to files:

.changeset/cold-webs-vanish.md

📚 Learning: 2025-11-24T18:03:52.013Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:03:52.013Z
Learning: Applies to **/.changeset/*.md : Changeset descriptions should be user-facing, use past tense for actions taken (e.g., 'Added new feature'), and present tense for Biome behavior (e.g., 'Biome now supports...'). Include issue links, rule links, and code examples where applicable.

Applied to files:

.changeset/cold-webs-vanish.md

📚 Learning: 2025-08-05T14:43:29.581Z

Learnt from: dyc3
Repo: biomejs/biome PR: 7081
File: packages/@biomejs/biome/configuration_schema.json:7765-7781
Timestamp: 2025-08-05T14:43:29.581Z
Learning: The file `packages/biomejs/biome/configuration_schema.json` is auto-generated and should not be manually edited or reviewed for schema issues; any changes should be made at the code generation source.

Applied to files:

.changeset/cold-webs-vanish.md

🪛 GitHub Actions: Pull request Markdown

.changeset/cold-webs-vanish.md

[error] 5-5: markdownlint MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

🪛 GitHub Check: lint

.changeset/cold-webs-vanish.md

[failure] 5-5: Trailing spaces
.changeset/cold-webs-vanish.md:5:169 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1] https://github.com/DavidAnson/markdownlint/blob/v0.39.0/doc/md009.md

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

GitHub Check: Documentation
GitHub Check: End-to-end tests
GitHub Check: Test (depot-windows-2022-16)
GitHub Check: Test (depot-ubuntu-24.04-arm-16)
GitHub Check: Lint project (depot-windows-2022)
GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
GitHub Check: Check Dependencies
GitHub Check: Test Node.js API
GitHub Check: autofix

.changeset/cold-webs-vanish.md

…s#8256) Co-authored-by: Emanuele Stoppa <[email protected]> Co-authored-by: Carson McManus <[email protected]>

Revert some of PR biomejs#7531 to re-enable logging

c29c8e5

That PR completely disabled logging because you can't just `impl Layer` without forwarding any of the 600 million methods.

github-actions bot added the A-CLI Area: CLI label Nov 25, 2025

cormacrelf changed the title ~~Revert some of PR #7531 to re-enable logging~~ fix(cli): Revert some of PR #7531 to re-enable logging Nov 25, 2025

ematipico approved these changes Nov 25, 2025

View reviewed changes

.changeset/cold-webs-vanish.md Outdated Show resolved Hide resolved

Update .changeset/cold-webs-vanish.md

fb296b8

coderabbitai bot reviewed Nov 25, 2025

View reviewed changes

.changeset/cold-webs-vanish.md Outdated Show resolved Hide resolved

dyc3 changed the title ~~fix(cli): Revert some of PR #7531 to re-enable logging~~ fix(cli): revert some of PR #7531 to re-enable logging Nov 25, 2025

dyc3 approved these changes Nov 25, 2025

View reviewed changes

.changeset/cold-webs-vanish.md Outdated Show resolved Hide resolved

Update .changeset/cold-webs-vanish.md

a41a32c

dyc3 merged commit f1e4696 into biomejs:main Nov 25, 2025
13 checks passed

This was referenced Nov 24, 2025

ci: release #8189

Merged

ci: release #8263

Merged

l0ngvh pushed a commit to l0ngvh/biome that referenced this pull request Dec 21, 2025

fix(cli): revert some of PR biomejs#7531 to re-enable logging (biomej…

3d2c560

…s#8256) Co-authored-by: Emanuele Stoppa <[email protected]> Co-authored-by: Carson McManus <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(cli): revert some of PR #7531 to re-enable logging #8256

fix(cli): revert some of PR #7531 to re-enable logging #8256

cormacrelf commented Nov 25, 2025

Uh oh!

changeset-bot bot commented Nov 25, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Nov 25, 2025 •

edited

Loading

Uh oh!

ematipico left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix(cli): revert some of PR #7531 to re-enable logging #8256

fix(cli): revert some of PR #7531 to re-enable logging #8256

Conversation

cormacrelf commented Nov 25, 2025

Summary

Test Plan

Docs

Uh oh!

changeset-bot bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

ematipico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Nov 25, 2025 •

edited

Loading

coderabbitai bot commented Nov 25, 2025 •

edited

Loading