Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

ci: restore WASM build in release#8264

Merged
dyc3 merged 2 commits intomainfrom
ci/restore-wasm-build-release
Nov 26, 2025
Merged

ci: restore WASM build in release#8264
dyc3 merged 2 commits intomainfrom
ci/restore-wasm-build-release

Conversation

@ematipico
Copy link
Member

@ematipico ematipico commented Nov 25, 2025

Summary

The latest release, and we believe it's the latest change in the WASM build

Test Plan

Docs

@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d9c69c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dyc3
dyc3 reviewed Nov 25, 2025
View reviewed changes
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 25, 2025 •
edited
Loading

Walkthrough

This pull request updates the GitHub Actions release workflow to replace a matrix-based WASM build with three explicit build steps for bundler, nodejs, and web. The build commands now run per-target with separate output directories, and the artifact upload step is adjusted to upload the three specific wasm output directories instead of using a matrix-derived artifact name or path. No public APIs or exported declarations were changed.

Possibly related PRs

  • ci: breakdown wasm CI build #8187: Modifies the same WASM build workflow but in the opposite direction—introduces a matrix strategy to replace explicit per-target steps.

Suggested labels

A-Project

Suggested reviewers

  • dyc3

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: restoring WASM build functionality in the release CI workflow, which directly aligns with the changeset's modifications to the release workflow.
Description check ✅ Passed The description mentions 'restore WASM build in release' and references the latest release, which relates to the changeset, though it lacks meaningful detail about what was changed or why.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/restore-wasm-build-release
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 03b935e and d9c69c9.

📒 Files selected for processing (1)
  • .github/workflows/release.yml (1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.8)
.github/workflows/release.yml

243-243: label "depot-ubuntu-24.04-arm-16" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-11-arm", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-26-xlarge", "macos-26", "macos-15-intel", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Nov 25, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b51968b and 03b935e.

📒 Files selected for processing (1)
  • .github/workflows/release.yml (1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.8)
.github/workflows/release.yml

243-243: label "depot-ubuntu-24.04-arm-16" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-11-arm", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-26-xlarge", "macos-26", "macos-15-intel", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

263-263: property "target" is not defined in object type {}

(expression)

🔇 Additional comments (2)
.github/workflows/release.yml (2)

253-258: LGTM: Explicit WASM build steps are well-structured.

The three sequential build steps for bundler, Node.js, and web targets are clear and correct. Each step properly specifies the target, output directory, and package scope.

265-267: LGTM: Artifact paths are comprehensive and accurate.

All three WASM package directories are explicitly specified and will be properly captured. The paths match the build step outputs.

@ematipico ematipico requested a review from dyc3 November 26, 2025 11:01
@dyc3 dyc3 merged commit ac0fb2d into main Nov 26, 2025
3 checks passed
@dyc3 dyc3 deleted the ci/restore-wasm-build-release branch November 26, 2025 14:20
@coderabbitai coderabbitai bot mentioned this pull request Nov 27, 2025
Merged
This was referenced Dec 15, 2025
Merged
Merged
l0ngvh pushed a commit to l0ngvh/biome that referenced this pull request Dec 21, 2025
@ematipico @l0ngvh
ci: restore WASM build in release (biomejs#8264)
dc0918e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@dyc3 dyc3 dyc3 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ematipico @dyc3