chore: extra rule sources #8740

Netail · 2026-01-11T16:21:31Z

Summary

Some extra rule sources :)

Test Plan

Docs

changeset-bot · 2026-01-11T16:21:35Z

🦋 Changeset detected

Latest commit: 0170f31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-01-11T16:25:23Z

Walkthrough

This PR updates rule declarations in the JavaScript analyzer to document their relationships with ESLint rules. It adds a changeset noting improved detection of rules in ESLint configurations, updates the OrganizeImports rule to reference sort-imports and no-duplicate-imports as inspired sources, and extends NoExcessiveCognitiveComplexity to include both EslintSonarJs and standard ESLint complexity as sources.

Possibly related PRs

docs: qwik no-react-props rule reference #8210: Updates rule declarations to add additional RuleSource entries for lint rules in crates/biome_js_analyze
docs: extra rule sources #7522: Modifies lint rule declarations to extend their RuleSource lists with extra ESLint-based sources
docs: node protocol rule reference #8328: Adds additional RuleSource entries to lint and source rule declarations in crates/biome_js_analyze

Suggested labels

A-Linter, L-JavaScript

Suggested reviewers

ematipico
dyc3
siketyan

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects the main change: adding extra rule sources to multiple lint rules in the codebase.
Description check	✅ Passed	The description is related to the changeset, though quite brief. It confirms the intent to add extra rule sources, which aligns with the actual changes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 95aba98 and 345c76c.

📒 Files selected for processing (3)

.changeset/some-maps-learn.md
crates/biome_js_analyze/src/assist/source/organize_imports.rs
crates/biome_js_analyze/src/lint/complexity/no_excessive_cognitive_complexity.rs

🧰 Additional context used

📓 Path-based instructions (1)

**/*.rs

📄 CodeRabbit inference engine (CONTRIBUTING.md)

**/*.rs: Use inline rustdoc documentation for rules, assists, and their options
Use the dbg!() macro for debugging output in Rust tests and code
Use doc tests (doctest) format with code blocks in rustdoc comments; ensure assertions pass in tests

Files:

crates/biome_js_analyze/src/lint/complexity/no_excessive_cognitive_complexity.rs
crates/biome_js_analyze/src/assist/source/organize_imports.rs

🧠 Learnings (22)

📓 Common learnings

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : When porting rules from other linters, use `sources` metadata with `RuleSource::Eslint().same()` for identical behavior or `.inspired()` for different behavior

📚 Learning: 2025-12-21T21:15:03.796Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-12-21T21:15:03.796Z
Learning: Changesets should describe user-facing changes only; internal refactoring without behavior changes does not require a changeset

Applied to files:

.changeset/some-maps-learn.md

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : When porting rules from other linters, use `sources` metadata with `RuleSource::Eslint().same()` for identical behavior or `.inspired()` for different behavior

Applied to files:

.changeset/some-maps-learn.md
crates/biome_js_analyze/src/lint/complexity/no_excessive_cognitive_complexity.rs
crates/biome_js_analyze/src/assist/source/organize_imports.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Biome linter rules must be designed to work across languages, requiring careful naming to indicate intended scope

Applied to files:

.changeset/some-maps-learn.md

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Deprecated rules must include a `deprecated` field in the `declare_lint_rule!` macro with an explanation of what rule to use instead

Applied to files:

crates/biome_js_analyze/src/lint/complexity/no_excessive_cognitive_complexity.rs
crates/biome_js_analyze/src/assist/source/organize_imports.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Rule names should use the `use` prefix when the rule's sole intention is to mandate a single concept

Applied to files:

crates/biome_js_analyze/src/lint/complexity/no_excessive_cognitive_complexity.rs
crates/biome_js_analyze/src/assist/source/organize_imports.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Rule names should use the `no` prefix when the rule's sole intention is to forbid a single concept

Applied to files:

crates/biome_js_analyze/src/lint/complexity/no_excessive_cognitive_complexity.rs
crates/biome_js_analyze/src/assist/source/organize_imports.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Use `declare_lint_rule!` macro with a `version` field set to `next` for new rules

Applied to files:

crates/biome_js_analyze/src/lint/complexity/no_excessive_cognitive_complexity.rs
crates/biome_js_analyze/src/assist/source/organize_imports.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : The first paragraph of rule documentation must be written in a single line to ensure proper rendering in the rules overview table

Applied to files:

crates/biome_js_analyze/src/lint/complexity/no_excessive_cognitive_complexity.rs
crates/biome_js_analyze/src/assist/source/organize_imports.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Implement the `action` function and add `fix_kind` metadata to the rule macro if the rule provides code actions

Applied to files:

crates/biome_js_analyze/src/lint/complexity/no_excessive_cognitive_complexity.rs
crates/biome_js_analyze/src/assist/source/organize_imports.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Use the `Semantic<T>` query type to access semantic information about bindings, references, and scope within a rule

Applied to files:

crates/biome_js_analyze/src/lint/complexity/no_excessive_cognitive_complexity.rs
crates/biome_js_analyze/src/assist/source/organize_imports.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Check if a variable is global using the semantic model before reporting diagnostics for rules that ban global functions or variables

Applied to files:

crates/biome_js_analyze/src/lint/complexity/no_excessive_cognitive_complexity.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Invalid code snippets in rule documentation must emit exactly one diagnostic

Applied to files:

crates/biome_js_analyze/src/lint/complexity/no_excessive_cognitive_complexity.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Rules in `complexity` groups must have severity set to `warn` or `info`

Applied to files:

crates/biome_js_analyze/src/lint/complexity/no_excessive_cognitive_complexity.rs

📚 Learning: 2025-12-22T09:26:56.943Z

Learnt from: ematipico
Repo: biomejs/biome PR: 8537
File: crates/biome_js_analyze/src/lint/nursery/no_leaked_render.rs:167-210
Timestamp: 2025-12-22T09:26:56.943Z
Learning: When defining lint rules (declare_lint_rule!), only specify fix_kind if the rule implements an action(...) function. Rules that only emit diagnostics without a code fix should omit fix_kind. This applies to all Rust lint rule definitions under crates/.../src/lint (e.g., crates/biome_js_analyze/src/lint/...).

Applied to files:

crates/biome_js_analyze/src/lint/complexity/no_excessive_cognitive_complexity.rs

📚 Learning: 2025-12-22T09:27:13.161Z

Learnt from: ematipico
Repo: biomejs/biome PR: 8537
File: crates/biome_js_analyze/src/lint/nursery/no_leaked_render.rs:167-210
Timestamp: 2025-12-22T09:27:13.161Z
Learning: In crates/biome_analyze/**/*analyze/src/**/*.rs, the `fix_kind` field in `declare_lint_rule!` should only be specified when the rule implements the `action` function. Rules that only emit diagnostics without providing code fixes should not include `fix_kind` in their metadata.

Applied to files:

crates/biome_js_analyze/src/assist/source/organize_imports.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : New rules must be placed inside the `nursery` group before promotion to other groups

Applied to files:

crates/biome_js_analyze/src/assist/source/organize_imports.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/biome_rule_options/lib/**/*.rs : Rule options must be defined in the `biome_rule_options` crate with a file named after the rule

Applied to files:

crates/biome_js_analyze/src/assist/source/organize_imports.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Use `rule_category!()` macro to refer to the diagnostic category instead of dynamically parsing its string name

Applied to files:

crates/biome_js_analyze/src/assist/source/organize_imports.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Code actions must pass `ctx.action_category(ctx.category(), ctx.group())` as the category parameter

Applied to files:

crates/biome_js_analyze/src/assist/source/organize_imports.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Use `Markup!` macro for diagnostic messages and code action descriptions to ensure proper formatting

Applied to files:

crates/biome_js_analyze/src/assist/source/organize_imports.rs

📚 Learning: 2025-11-24T18:04:57.309Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_diagnostics/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:04:57.309Z
Learning: Applies to crates/biome_diagnostics/**/*.rs : Use helper types from the biome_diagnostics::v2 module (CodeFrameAdvice, CommandAdvice, DiffAdvice, LogAdvice) or implement the Advices trait yourself for custom advice handling

Applied to files:

crates/biome_js_analyze/src/assist/source/organize_imports.rs

🧬 Code graph analysis (2)

crates/biome_js_analyze/src/lint/complexity/no_excessive_cognitive_complexity.rs (1)

crates/biome_analyze/src/rule.rs (3)

sources (640-643)

same (255-260)

inspired (263-268)

crates/biome_js_analyze/src/assist/source/organize_imports.rs (1)

crates/biome_analyze/src/rule.rs (2)

sources (640-643)

inspired (263-268)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)

GitHub Check: Test Node.js API
GitHub Check: Check Dependencies
GitHub Check: Test (depot-ubuntu-24.04-arm-16)
GitHub Check: Documentation
GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
GitHub Check: Lint project (depot-windows-2022)
GitHub Check: Test (depot-windows-2022-16)
GitHub Check: End-to-end tests
GitHub Check: autofix
GitHub Check: Bench (biome_js_formatter)
GitHub Check: Bench (biome_js_analyze)
GitHub Check: Bench (biome_js_parser)

🔇 Additional comments (4)

crates/biome_js_analyze/src/assist/source/organize_imports.rs (2)

2-3: LGTM!

The RuleSource import is properly added to support the new sources metadata field.

655-655: The sources field is correct as implemented.

Both ESLint rules are accurately referenced, and .inspired() is the right modifier since OrganizeImports extends their functionality with grouping, deduplication, and custom ordering beyond what either individual rule provides.

.changeset/some-maps-learn.md (1)

1-5: LGTM!

The changeset appropriately describes the user-facing benefit of adding rule source metadata. A patch release is correct for this improvement to migration tooling.

crates/biome_js_analyze/src/lint/complexity/no_excessive_cognitive_complexity.rs (1)

71-71: The change is correct.

ESLint's "complexity" rule measures cyclomatic complexity (McCabe's method), which differs from the cognitive complexity algorithm used here. Using .inspired() appropriately reflects this distinction and helps users migrating from ESLint configurations. The pair of sources—.same() for SonarJS and .inspired() for ESLint—is a sensible approach.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codspeed-hq · 2026-01-11T16:41:44Z

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing Netail:chore/extra-eslint-sources (0170f31) with main (95aba98)}

Summary

✅ 58 untouched benchmarks
⏩ 95 skipped benchmarks¹

95 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

chore: extra rule sources

345c76c

github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jan 11, 2026

ematipico approved these changes Jan 11, 2026

View reviewed changes

[autofix.ci] apply automated fixes

0170f31

github-actions bot added the A-CLI Area: CLI label Jan 11, 2026

Netail merged commit 4962ed0 into biomejs:main Jan 11, 2026
18 checks passed

Netail deleted the chore/extra-eslint-sources branch January 11, 2026 16:54

github-actions bot mentioned this pull request Jan 11, 2026

ci: release #8671

Merged

coderabbitai bot mentioned this pull request Jan 24, 2026

feat(assist): add noDuplicateClasses assist action #8623

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: extra rule sources #8740

chore: extra rule sources #8740

Netail commented Jan 11, 2026

Uh oh!

changeset-bot bot commented Jan 11, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Jan 11, 2026

Uh oh!

codspeed-hq bot commented Jan 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

chore: extra rule sources #8740

chore: extra rule sources #8740

Conversation

Netail commented Jan 11, 2026

Summary

Test Plan

Docs

Uh oh!

changeset-bot bot commented Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Jan 11, 2026

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Uh oh!

codspeed-hq bot commented Jan 11, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Summary

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot bot commented Jan 11, 2026 •

edited

Loading