Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: qwik no-react-props rule reference #8210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Netail merged 3 commits into from
Nov 22, 2025
Merged

docs: qwik no-react-props rule reference #8210

Netail merged 3 commits into from
Nov 22, 2025
+14 −1

Conversation

@Netail
Copy link
Member

@Netail Netail commented Nov 21, 2025

Summary

Missing qwik rule reference

Test Plan

Docs

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 6e932b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Nov 21, 2025
@Netail Netail changed the title docs: no-react-props docs: qwik no-react-props rule reference Nov 21, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 21, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The NoReactSpecificProps lint rule declaration was changed to include an additional ESLint rule source. It now lists both RuleSource::EslintSolid("no-react-specific-props") and RuleSource::EslintQwik("no-react-props") as sources; all other behavior is unchanged.

Possibly related PRs

  • docs: rules.rs cleanup #8044: Introduced the EslintQwik variant and expanded ESLint rule source variants, which aligns with adding EslintQwik("no-react-props") here.

Suggested reviewers

  • dyc3
  • ematipico

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'docs: no-react-props' is vague and generic—it mentions documentation and a rule name but doesn't clearly convey what the actual change is (adding Qwik rule reference to the NoReactSpecificProps lint rule). Consider a more descriptive title like 'Add Qwik rule reference to NoReactSpecificProps lint' to clarify the actual code change rather than just mentioning documentation.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The description 'Missing qwik rule reference' is directly related to the changeset, which adds an EslintQwik rule source to the NoReactSpecificProps lint rule.
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1503cd8 and 6e932b8.

⛔ Files ignored due to path filters (1)
  • crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs is excluded by !**/migrate/eslint_any_rule_to_biome.rs and included by **
📒 Files selected for processing (1)
  • .changeset/rare-seas-hunt.md (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the A-CLI Area: CLI label Nov 21, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 21, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8210 will not alter performance

Comparing Netail:docs/qwik-no-react-props (6e932b8) with main (79adaea)

Summary

✅ 58 untouched
⏩ 95 skipped1

Footnotes

  1. 95 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@dyc3
Copy link
Contributor

dyc3 commented Nov 22, 2025

Could use a small changeset.

@Netail Netail added this pull request to the merge queue Nov 22, 2025
Merged via the queue into biomejs:main with commit 7b44e9e Nov 22, 2025
16 of 17 checks passed
@Netail Netail deleted the docs/qwik-no-react-props branch November 22, 2025 00:44
This was referenced Nov 22, 2025
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Dec 12, 2025
Merged
l0ngvh pushed a commit to l0ngvh/biome that referenced this pull request Dec 21, 2025
@Netail @autofix-ci @l0ngvh
docs: qwik no-react-props rule reference (biomejs#8210)
1b36050 
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dyc3 dyc3 dyc3 approved these changes

Assignees

No one assigned

Labels

A-CLI Area: CLI A-Linter Area: linter L-JavaScript Language: JavaScript and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Netail @dyc3