-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Honeycomb v3.3.0 #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+9,543
−14,369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: Electron forge config file
Variable was not used on the renderer
I've been having some issues with the app.isPackaged?
RobertGemmaJr
commented
Mar 12, 2024
RobertGemmaJr
commented
Mar 12, 2024
RobertGemmaJr
commented
Mar 12, 2024
RobertGemmaJr
commented
Mar 12, 2024
RobertGemmaJr
commented
Mar 12, 2024
broarr
approved these changes
Mar 13, 2024
broarr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is way too big for me to provide a good review. I skimmed the code and didn't see anything glaring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR is bringing all of the previous changes into main,
feat-v3.3is just a holding branch. All of the code has been looked at in other PRs. 3.3 is just about ready to be released!What's Changed
Electron
forge.config.jspreloadscript is added to bridge between the Electron and renderer processesuniversalbinaryFirebase
The default Firestore rules now allow any
participantIDandstudyIDcombination to be used at runtime. This is how all of the labs have been using their Firebase so I figured it should stay. The previous rules (the studyID and participantID must be registered somewhere else in the Firestore) are present but commented outExperiment
src/experimentphotodiodeGhostBoxis always added as thepromptof the trialpdSpotEncodefunction is always called onon_loadcallback of the trialblocksare now referred to asproceduresMiscellaneous
no-unused-varsis now a warning with eslintfunction(){}over callback functions@brown-ccv