(#28) Fix New-CCMDeploymentStep 400 Error #30
Conversation
|
|
||
| try{ | ||
| $null = Invoke-RestMethod @irmParams -ErrorAction Stop | ||
| $null = Invoke-RestMethod @irmParams -ErrorAction Stop -Proxy 'http://127.0.0.1:8888' |
There was a problem hiding this comment.
@steviecoaster you aren't going to need this part anymore
There was a problem hiding this comment.
@steviecoaster this still needs to be removed here as well.
| @@ -1,107 +1,107 @@ | |||
| # Add-CCMGroup | |||
There was a problem hiding this comment.
Should the entire gen folder be excluded from source control?
| GUID = '7097e495-f5e0-4d7f-acba-8e2bbeb354af' | ||
|
|
||
| # Author of this module | ||
| Author = 'Stephen Valdinger' |
There was a problem hiding this comment.
I think we need to remove this file from source control, right?
|
There seems to be a little bit more going on in here than just the fixing of the 400 error. Should we break this into different commits, referencing different issues? |
|
Hmm. The gen stuff is in the gitignore. I am probably holding that wrong. I can break things apart a bit, sure. |
|
@steviecoaster if the files were already added to the repository, which it looks like they were, adding the entry into the .gitignore file won't actually do anything. Git can't ignore the files, as they are already in the repository. You would first need to delete all the files, then the entry in the .gitignore file will be respected, and the files won't be added back in again. |
|
@steviecoaster did we decide whether or not the generated files should be removed from this repository? If so, I think they still need to be deleted, as they are currently all being edited within this PR. Were there issues for the other commits that are in this PR? If so, it would be good to add a link to them, and if not, it would be good to get ones added, so that they can form the basis of the release notes for the release. |
|
#2 was created and closed for the I don't think the generated files have no business here in this repo, they need to go over to the docs repo, (They are, it's just manually as I need this code base to generate them). I believe one of the commits on this PR will remove them from the Repo once this gets merged, if I'm understanding the gits correctly (good chance I'm not). |
|
|
||
| try{ | ||
| $null = Invoke-RestMethod @irmParams -ErrorAction Stop | ||
| $null = Invoke-RestMethod @irmParams -ErrorAction Stop -Proxy 'http://127.0.0.1:8888' |
There was a problem hiding this comment.
@steviecoaster this still needs to be removed here as well.
| { | ||
| param($Command,$Parameter,$WordToComplete,$CommandAst,$FakeBoundParams) | ||
| $r = (Get-CCMDeployment -All).Name | ||
| $r = (Get-CCMDeployment).Name |
There was a problem hiding this comment.
@steviecoaster I don't think that this is meant to be in this commit.
| { | ||
| param($Command,$Parameter,$WordToComplete,$CommandAst,$FakeBoundParams) | ||
| $r = (Get-CCMGroup -All).Name | ||
| $r = (Get-CCMGroup).Name |
There was a problem hiding this comment.
@steviecoaster I don't think this is meant to be in this commit.
Yes, I believe a follow up issue, linking to the first one, would be the best course of action here. Once the issue is created, the commit message in this PR can be updated to point at it.
Assuming you are talking about this commit the only changes that I can see being made there is to edit the existing files. They are not yet being deleted from the repository. Let me know if you want to try to grab some time to go through this. |
|
@steviecoaster I have taken the liberty of creating a new PR which I believe addresses some of the concerns that I have raised. All the work that was contained in this PR has been moved into the new PR, and it also addresses some more items. I would suggest that we close this PR, and begin review on the new PR. Let me know if you have any questions. |
This PR addresses a bug where creating a new Deployment step throws a 400 error.
The endpoints for Basic and Advanced are slightly different, and Basic requires the choco command be lowercase.
Fixes #28