General updates to the repository, including fixing some bugs #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since these are generated as part of the build, they don't belong in source control, as they will be recreated each time the build runs. Co-authored-by: Stephen Valdinger <[email protected]>
To prevent any generated files making their way back into the repository
This was previously removed from other places as part of #2, but a couple instances still remained. Co-authored-by: Stephen Valdinger <[email protected]>
Co-authored-by: Stephen Valdinger <[email protected]>
At some point in the future, this will be replaced by an automated process that doesn't require human intervention. Co-authored-by: Stephen Valdinger <[email protected]>
|
LGTM! |
steviecoaster
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of the PR that was created here and addressed some of the issues that were raised in that PR.
Fixes #31
Fixes #32
Fixes #33
Fixes #34
Fixes #28