[#89] Add 'putStdoutColoured' and 'putStderrColoured' #92
Conversation
|
Hi @Dponya 👋🏻 I see that @lillycat332 already opened a PR to resolve the same issue but they were slightly faster 😅 I still accept your contribution so it should be accepted for Hacktoberfest nevertheless 👍🏻 |
Oh, oops. Sorry for that, I thought there is two independent issues #90 and #89. One for replacing |
|
@Dponya My bad 🙏🏻 Indeed, I confused two issues 😮💨 In that case, I see no problem and no conflict! 👌🏻 |
chshersh
left a comment
There was a problem hiding this comment.
Thanks, looks great!
I have only minor suggestions. Also, could you please add your changes to the CHANGELOG in the [unreleased] section? 🙏🏻
src/Iris/Colour/Formatting.hs
Outdated
| "my message" | ||
| @ | ||
| @since 0.0.0.0 |
There was a problem hiding this comment.
Let's specify the x.x.x.x version for all new functions in types. I'll run a command to update all versions before the next release when the actual release version is known
| @since 0.0.0.0 | |
| @since x.x.x.x |
…tdoutcoloured-and-putstderrcoloured
| $ BSL.toStrict $ TLE.encodeUtf8 x | ||
| printLine x = Iris.putStdoutColoured | ||
| (Colourista.formatWith [TS.empty]) | ||
| $ T.toStrict $ x `mappend` "\n" |
There was a problem hiding this comment.
There I used putStdoutColoured without Ln for stable purposes. When the API of putStdoutColouredLn will be changed from ByteString to Text, there could be a need to change simple-grep too. So, I just used \n
Resolves #89
Additional tasks