[#90] Change types in 'Iris.Colour.Formatting' from 'ByteString' to 'Text' #91
Conversation
|
We can probably also remove the bytestring dependency if we merge this? |
chshersh
left a comment
There was a problem hiding this comment.
Thanks, looks great! Nice and simple 🙂
I have one comment about the changelog entry but the rest looks great 👍🏻
chshersh
left a comment
There was a problem hiding this comment.
Everything looks great 👍🏻
I see a GHC warning about unused import. I believe, it's the only remaining part 🙂
src/Iris/Colour/Formatting.hs
Outdated
| import Control.Monad.IO.Class (MonadIO (..)) | ||
| import Control.Monad.Reader (MonadReader) | ||
| import Data.ByteString (ByteString) | ||
| import qualified Data.Text as T |
There was a problem hiding this comment.
GHC outputs the warning that this import is redundant. I believe, only IO functions from Text are used so this one can be removed 🧹
There was a problem hiding this comment.
Removed the redundant import, though it now won't compile though as the simple-grep uses ByteString still.
There was a problem hiding this comment.
Will open a PR to fix that after this is merged 😄
962c4ed to
7056b0e
Compare
chshersh
left a comment
There was a problem hiding this comment.
Looks fine then 👌🏻
@lillycat332 Could you resolve conflicts so I can merge the PR? Thanks!
|
Done 🙂 |
Resolves #90
I have changed the ByteString usage in Iris.Colour.Formatting to Data.Text.
Additional tasks